Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/provider round cost #807

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Fix/provider round cost #807

merged 1 commit into from
Nov 23, 2020

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Nov 19, 2020

NGNT precision is 18 decimal places. Rounding up prevents payment errors.

@Wiezzel Wiezzel closed this Nov 19, 2020
@Wiezzel Wiezzel reopened this Nov 19, 2020
@Wiezzel Wiezzel changed the base branch from master to release/v0.5 November 19, 2020 15:55
@Wiezzel Wiezzel force-pushed the fix/provider_round_cost branch 2 times, most recently from 801561c to fc26982 Compare November 23, 2020 12:05
@Wiezzel Wiezzel requested a review from maaktweluit November 23, 2020 12:06
@Wiezzel Wiezzel self-assigned this Nov 23, 2020
@Wiezzel Wiezzel marked this pull request as ready for review November 23, 2020 12:06
@Wiezzel Wiezzel force-pushed the fix/provider_round_cost branch from fc26982 to d1e412a Compare November 23, 2020 12:22
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

NGNT precision is 18 decimal places. Rounding up prevents payment errors.

Signed-off-by: Adam Wierzbicki <[email protected]>
@Wiezzel Wiezzel force-pushed the fix/provider_round_cost branch from d1e412a to 56b3826 Compare November 23, 2020 12:25
@Wiezzel Wiezzel merged commit 325b281 into release/v0.5 Nov 23, 2020
@Wiezzel Wiezzel deleted the fix/provider_round_cost branch November 23, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants