Payment driver: ValidateAllocation #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
force-pushed
the
wiezzel/validate_allocation
branch
from
22baf3a to
2a7b92b
Compare
Added a new GSB endpoint to the payment driver API to validate whether an allocation could be created (check available funds). Signed-off-by: Adam Wierzbicki <[email protected]>
Wiezzel
force-pushed
the
wiezzel/validate_allocation
branch
from
2a7b92b to
a637ad1
Compare
maaktweluit
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new GSB endpoint to the payment driver API to validate whether an allocation could be created (check available funds).
Testing:
a) Regression: Just run
payment_api --driver=zksync+invoice_flowb) Insufficient funds: change line 39 in
invoice_flowto make an allocation for 1000000 GNT. Runpayment_api --driver=zksync+invoice_flow. Should fail with an error like this:c) Invalid account: change line 37 in
invoice_flowand put there some bogus address. Runpayment_api --driver=zksync+invoice_flow. Should fail with an error like this: