Update account not registered error with hint #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
reviewed
Oct 5, 2020
core/payment/src/error.rs
Outdated
| @@ -112,7 +112,7 @@ pub mod processor { | |||
| use ya_core_model::payment::public::SendError; | |||
|
|
|||
| #[derive(thiserror::Error, Debug)] | |||
| #[error("Account not registered. platform={platform} address={address} mode={mode:?}")] | |||
| #[error("Account not registered. Hint: Did you run `yagna payment init -r` after restarting? platform={platform} address={address} mode={mode:?}")] | |||
There was a problem hiding this comment.
The flag in the error message should depend on mode field. In case of receiving payments it's -p.
There was a problem hiding this comment.
i thought this was not needed since -p is called by default
There was a problem hiding this comment.
Well, it's called by default but only for the default identity. It is possible to create a new identity and not call init.
There was a problem hiding this comment.
good one! added the -r or -p dependent on the mode
Wiezzel
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help users resolve this error themselves: Add a hint that solves this problem in 99% of the cases.