Testing proposal timeout branch in goth #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
force-pushed
the
mwu/proposal_timeout
branch
from
8f0b63b to
470f94b
Compare
goth_tests/pyproject.toml
Outdated
| @@ -23,7 +23,7 @@ pytest-asyncio = "^0.14" | |||
| # goth = "^0.7" | |||
| # to use development goth version uncomment below | |||
| # goth = { git = "https://github.com/golemfactory/goth.git", branch = "fix-flaky-tests-wait_for_proposals" } | |||
| goth = { git = "https://github.com/golemfactory/goth.git", rev = "b5b4ad3c4156899781888f12c9e614ad7f734af9" } | |||
| goth = { git = "https://github.com/golemfactory/goth.git", branch = "master" } | |||
There was a problem hiding this comment.
I think we should reference specific commit on master
There was a problem hiding this comment.
the lock file already references a specific commit, but can update this :)
nieznanysprawiciel
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend negotiation ( wait for proposal ) timeout to 30 seconds because braodcasts can collide and get ignored.
This ensures 8-10 broadcast can go through compared to the 1-2 with the lower timeout