Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose net implementation (Hybrid/Central) using ENV variable #1666

Merged
merged 11 commits into from
Nov 22, 2021
Merged

Choose net implementation (Hybrid/Central) using ENV variable #1666

merged 11 commits into from
Nov 22, 2021

Conversation

nieznanysprawiciel
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel commented Oct 28, 2021 •
edited
Loading

Use ENV vars:
YA_NET_TYPE=hybrid
YA_NET_TYPE=central

Central Net is used by default

@nieznanysprawiciel nieznanysprawiciel self-assigned this Oct 28, 2021
maaktweluit
maaktweluit previously approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I though we would stick with the feature flag, now a lot of my work on goth is redundant.

@nieznanysprawiciel nieznanysprawiciel marked this pull request as ready for review November 2, 2021 14:30
@nieznanysprawiciel nieznanysprawiciel requested review from a team November 2, 2021 14:30
mfranciszkiewicz
mfranciszkiewicz reviewed Nov 19, 2021
View reviewed changes
@nieznanysprawiciel nieznanysprawiciel removed the request for review from a team November 19, 2021 14:36
@nieznanysprawiciel nieznanysprawiciel linked an issue Nov 19, 2021 that may be closed by this pull request
Choose net based on env variable #1689
Closed
@nieznanysprawiciel nieznanysprawiciel merged commit bdfa046 into master Nov 22, 2021
@nieznanysprawiciel nieznanysprawiciel deleted the net/configuration-in-env branch November 22, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranciszkiewicz mfranciszkiewicz mfranciszkiewicz approved these changes

@maaktweluit maaktweluit maaktweluit left review comments

Assignees

@nieznanysprawiciel nieznanysprawiciel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choose net based on env variable
3 participants
@nieznanysprawiciel @mfranciszkiewicz @maaktweluit