Polygon basic support #1644
Polygon basic support #1644
Conversation
…a that caused payment transactions to be blocked.
| format!("Goerli faucet not supported") | ||
| } | ||
| Network::Polygon => format!( | ||
| r#"Your mainnet/polygon ethereum address is {}. |
There was a problem hiding this comment.
do we still (manually) donate mainnet funds to requestors?
if so its better to copy the text from the zksync / mainnet / fund call and update it to polygon / matic:
| .unwrap_or("0x33af15c79d64b85ba14aaffaa4577949104b22e8".to_string()) | ||
| ) | ||
| .unwrap(), | ||
| glm_faucet_address: None, |
There was a problem hiding this comment.
no faucet on goerli?
we can deploy the faucet from the GNT2 repo if needed
There was a problem hiding this comment.
No faucet on Goerli, more important is faucet on Mumbai.
| .unwrap_or("0x2036807B0B3aaf5b1858EE822D0e111fDdac7018".to_string()) | ||
| ) | ||
| .unwrap(), | ||
| glm_faucet_address: None, |
There was a problem hiding this comment.
Unfortunately there is no faucet available yet, we can add feature request to task to prepare faucet for MUMBAI
| network is under-utilised right now so 30.1 should result in express transactions | ||
| USD cost as of 2021-10-08 of transaction is about 0,16 cents (USD) | ||
| */ | ||
|
|
There was a problem hiding this comment.
very nitty, but i would move this whitespace above the comment
| let str_addr = format!("0x{:x}", &address); | ||
| let db_nonce = dao.get_next_nonce(&str_addr, network).await?; | ||
| Ok(std::cmp::max(network_nonce, db_nonce)) | ||
|
|
||
| if network_nonce != db_nonce { |
There was a problem hiding this comment.
we had a lot of cases with slow syncing geth nodes where the db_nonce > network_nonce
Are you sure you want to use the network as default? recommend to still return the max()
There was a problem hiding this comment.
I'll resolve this problem in the next version of payment driver.
No description provided.