Disable foreign key checks for running DB migrations

Some migrations require disabling foreign key checks for advanced table manipulation. Unfortunately, disabling foreign keys within migration doesn't work correctly. Signed-off-by: Adam Wierzbicki <[email protected]>
golemfactory · Jan 28, 2021 · db3f329 · db3f329
1 parent 4d4fa94
commit db3f329
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/core/persistence/src/executor.rs b/core/persistence/src/executor.rs
@@ -95,7 +95,12 @@ impl DbExecutor {
         migration: T,
     ) -> anyhow::Result<()> {
         let c = self.conn()?;
-        Ok(migration(&c, &mut std::io::stderr())?)
+        // Some migrations require disabling foreign key checks for advanced table manipulation.
+        // Unfortunately, disabling foreign keys within migration doesn't work correctly.
+        c.batch_execute("PRAGMA foreign_keys = OFF;")?;
+        migration(&c, &mut std::io::stderr())?;
+        c.batch_execute("PRAGMA foreign_keys = ON;")?;
+        Ok(())
     }
 
     pub async fn with_connection<R: Send + 'static, Error, F>(&self, f: F) -> Result<R, Error>