Create a module for building yagna Docker images #325
Conversation
kmazurek
changed the title
goth/runner/container/build.py
Outdated
| class YagnaBuildEnvironment: | ||
| """Configuration for the Docker build process of a yagna image.""" | ||
|
|
||
| archive_path: Optional[Path] |
There was a problem hiding this comment.
@zakaprov are all of these properties independent? ... my common sense tells me you'd only ever need just one of them? ...
There was a problem hiding this comment.
I agree: archive_path and binary_dir could me made a single property.
There was a problem hiding this comment.
Sure, I can merge those into a single parameter which will handle all three cases (i.e. directory, single binary and archive).
|
|
||
|
|
||
| @dataclass(frozen=True) | ||
| class YagnaBuildEnvironment: |
There was a problem hiding this comment.
given that all the functions in this file use "environment" as an argument - wouldn't it rather make sense for them all to be methods of the YagnaBuildEnvironment class?
There was a problem hiding this comment.
IMHO in this case it's mainly a matter of style and personal preferences. I like it this (i.e. non-OO) way. Plus, it makes it more clear that YagnaBuildEnvironment is immutable (for what it's worth).
goth/runner/container/build.py
Outdated
| context_deb_dir.mkdir() | ||
|
|
||
| if env.binary_dir: | ||
| logger.info("using local yagna binaries. path=%s", env.binary_dir) |
There was a problem hiding this comment.
We don't have any convention for this, but just for the record: I prefer log messages starting with a capital letter.
There was a problem hiding this comment.
Now that you mentioned this I noticed that most of the INFO logs that we have start with capitals. Fine with me, I'll update these.
Co-authored-by: azawlocki <[email protected]>
Resolves: #317
Summary of changes:
goth/runner/container/build.pywhich handles building the Docker image for yagnadocker buildgoth/runner/container/compose.py#start_networkdocker/yagna-goth.Dockerfileanddocker/docker-compose.ymlhave been updated to reflect the updated build processgothsubtree underrunner/downloadscriptsdirectory under the project rootdirs_exist_okparameter onshutil.copytree)_run_commandfunction fromrunner/container/compose.pyhas been extracted to a separate module underrunner/process.py