JST-484: Use whitelist in project templates #90
Closed
+360
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grisha87
commented
Nov 14, 2023
grisha87
changed the title
pgrzy-golem
reviewed
Nov 15, 2023
There was a problem hiding this comment.
I think this is outside of the scope of simple golem project.
If we consider this pretty much a default implementation that is a minimum for all apps to use, we should either add it to the SDK or provide a new npm package like golem-sdk/default-strategies or something similar.
grisha87
force-pushed
the
feature/JST-484/use-whitelist-by-templates
branch
from
22ffcb2 to
22c385d
Compare
grisha87
force-pushed
the
feature/JST-484/use-whitelist-by-templates
branch
from
22c385d to
19e9971
Compare
grisha87
force-pushed
the
feature/JST-484/use-whitelist-by-templates
branch
from
19e9971 to
5453a6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining scope: