-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Sounds stop playing after context is interrupted (fixes #928) #1106
Conversation
@goldfire can you please take a look? it's a relatively small one 🙃 |
@goldfire I've added |
@goldfire any chance of getting this in? |
@goldfire is this being ignored? Because this is an issue for us in prod. |
@goldfire why is this PR not merged? This is an issue for us in prod. |
@abdurrahmancuce you can use |
Sorry, I must have missed this one! Thanks for finding the solution to this. I've gotten it tested now and will have it released later today in 2.2.0. |
@goldfire thank you very much! |
In Safari browser on iOS when browser tab loses focus the audio context gets interrupted. If during this inactivity the "_autoSuspend" timeout fires, Howler is set to the
suspending
state, but theself.ctx.suspend()
promise gets rejected, so Howler is never switched to thesuspended
state (which would allow the_autoResume
method to perform).Steps to reproduce:
autoSuspend
property should be set totrue
)suspending
state