Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Chrome deprecation warnings. #856

Closed
tammesalu opened this issue Nov 21, 2017 · 9 comments
Closed

Google Chrome deprecation warnings. #856

tammesalu opened this issue Nov 21, 2017 · 9 comments

Comments

@tammesalu
Copy link

Google Chrome is giving me following warnings when I use Howler in my project:

howler.js:2213 [Deprecation] GainNode.gain.value setter smoothing is deprecated and will be removed in M64, around January 2018. Please use setTargetAtTime() instead if smoothing is needed. See https://www.chromestatus.com/features/5287995770929152 for more details.

[Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018 See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.

Does anyone know what are those warnings and can they be addressed in Howlers code?

@klaasman
Copy link

It is only a couple of weeks left until January, so is it possible to have this fix released to NPM?

@goldfire
Copy link
Owner

This just got pushed to npm in 2.0.6.

@klaasman
Copy link

Great, thanks!

@Stenerson
Copy link
Contributor

I'm still getting the following deprecation warning in 2.0.7

[Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018 See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.

It appears that 0b538a7 only addressed the issue with GainNode.gain.value but the issues with rate still exist.

The culprit is here:
sound._node.bufferSource.playbackRate.value = sound._rate;

This should probably also be updated:
sound._node.bufferSource.playbackRate.value = rate;

@goldfire
Copy link
Owner

@Stenerson Thanks! Just fixed this with dc0a2cf and will try to get a 2.0.8 release out soon.

@julesongithub
Copy link

julesongithub commented Jan 25, 2018

Is the first warning a breaking change?

"GainNode.gain.value setter smoothing is deprecated and will be removed in M64"

I've just updated to M64 and, though I still get the warning, the audio still works.

Edit: I've looked into it and as far as I can see, it's not a breaking change, it just means that the Gain will be set immediately instead of smoothly (unless setTargetTime is used instead). If that's so, I can live with that and just update projects as other changes are made.

bhaskarp-vg pushed a commit to ValueGlobal/howler.js that referenced this issue Feb 7, 2018
@DFortun81
Copy link

DFortun81 commented Feb 8, 2018

[Deprecation] AudioParam value setter will become equivalent to AudioParam.setValueAtTime() in M65, around March 2018 See https://webaudio.github.io/web-audio-api/#dom-audioparam-value for more details.

The error is in reference to sound._node.bufferSource.playbackRate.value = sound._rate; within the _refreshBuffer function.

EDIT: Nevermind, I didn't see the update.

@goldfire
Copy link
Owner

goldfire commented Feb 8, 2018

@DFortun81 That was fixed in v2.0.8.

@DFortun81
Copy link

Yeah, sorry. I didn't see the update.

ringcrl pushed a commit to ringcrl/howler.js that referenced this issue Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants