Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR Add tslint-config-security MINOR eslint-config-security image #270

Merged
merged 1 commit into from
Oct 17, 2018
Merged

MINOR Add tslint-config-security MINOR eslint-config-security image #270

merged 1 commit into from
Oct 17, 2018

Conversation

js-kyle
Copy link
Contributor

@js-kyle js-kyle commented Oct 17, 2018

No description provided.

@goldbergyoni goldbergyoni self-assigned this Oct 17, 2018
goldbergyoni
goldbergyoni reviewed Oct 17, 2018
View reviewed changes
Copy link
Owner

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@goldbergyoni goldbergyoni assigned js-kyle and unassigned goldbergyoni Oct 17, 2018
goldbergyoni
goldbergyoni approved these changes Oct 17, 2018
View reviewed changes
Copy link
Owner

@goldbergyoni goldbergyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this time with approval

@js-kyle js-kyle merged commit 5600c89 into master Oct 17, 2018
@js-kyle js-kyle deleted the 6.1_fixes branch October 17, 2018 07:53
@goldbergyoni goldbergyoni mentioned this pull request Jun 5, 2020
Closed
elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
@js-kyle
Merge pull request goldbergyoni#270 from i0natan/6.1_fixes
e7e2bf1 
MINOR Add tslint-config-security MINOR eslint-config-security image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldbergyoni goldbergyoni goldbergyoni approved these changes

Assignees

@js-kyle js-kyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js-kyle @goldbergyoni