Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Intuit to README.md #936

Merged
merged 3 commits into from
Jan 30, 2020
Merged

Add Intuit to README.md #936

merged 3 commits into from
Jan 30, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 22, 2020

Note that we Open Source code under the argoproj org as well as intuit org.

@claassistantio
Copy link

claassistantio commented Jan 22, 2020

CLA assistant check
All committers have signed the CLA.

README.tmpl.md Outdated
@@ -125,6 +125,7 @@ The following companies/products use golangci-lint:
* [Red Hat OpenShift](https://github.com/openshift/telemeter)
* [Yahoo](https://github.com/yahoo/yfuzz)
* [IBM](https://github.com/ibm-developer/ibm-cloud-env-golang)
* [Intuit](https://github.com/argoproj)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably makes sense to say Argo Project rather than Intuit since that's what it links to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting one - should we list both? we use it at Intuit on our OSS projects, which are published in various places including https://github.com/intuit

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding both links would be fine. In general, I think it's important for the descriptions to be precise about what they link to.

Copy link
Contributor

@tpounds tpounds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tpounds tpounds merged commit 4f3e410 into golangci:master Jan 30, 2020
korjavin pushed a commit to korjavin/golangci-lint-1 that referenced this pull request Mar 10, 2020
* tag 'v1.23.7': (140 commits)
  dev: prepare v1.23.7
  autogenerated_exclude: increase scanner max buffer size
  dev: use go1.14
  change increase to increasing in timeout error
  dev: release v1.23.6
  tools: update goreleaser
  dev: release v1.23.5
  Support Go 1.14rc1.
  Simplify alpine Dockerfile
  add missing mips option
  Update to latest x/tools (golangci#930)
  fix golangci#869 by removing lock file after unlocking (golangci#947)
  dev: release v1.23.3
  autogenerated_exclude: increase scanner buffer (golangci#955)
  gocritic: update disabled check warning message
  Add MIPS arch support
  dev: release v1.23.2
  Fix misspelled words. (golangci#952)
  Add Intuit to README.md (golangci#936)
  fix golangci.yml reference
  ...
@ldez ldez added the area: docs label Dec 7, 2020
@ldez ldez added this to the v1.23 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants