fix: improve Go version detection inside workspace #5179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4894
To reproduce
Note
By adding
golang.org/x/mod
as a dependency, a bug inside the integration test forgomodguard
has been detected.The test used the
go.mod
of golangci-lint instead of a dedicatedgo.mod
so we never saw the problem.The module defined inside the
allowed
section was not a module but a package (golang.org/x/mod/modfile
) and as thego.mod
of golangci-lint didn't containgolang.org/x/mod
the problem was hidden.So I fixed the test because without that, the CI was unhappy with this PR.