Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/nunnatsa/ginkgolinter from 0.16.2 to 0.17.0 #5093

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 29, 2024

Bumps github.com/nunnatsa/ginkgolinter from 0.16.2 to 0.17.0.

Release notes

Sourced from github.com/nunnatsa/ginkgolinter's releases.

v0.17.0

What's Changed

  • Bug fix: missing async validations

    • the linter now checks error with nil assertion also in async assertions as well, such as:
      Eventually(func() err {return nil}).Should(BeNil())
    • the linter now checks for MatchError issues in async assertions as well, e.g.
      Eventually(func() string {return "hello"}).Should(MatchError("hello"))
  • Bug fix: handle Equal(true/false) in Expect(p == nil).To(Equal(true/false)) even when nil assertion is suppressed; e.g.

    Expect(p == nil).To(Equal(true))
    // will be changed to:
    Expect(p == nil).To(BeTrue())
  • Bug fix: force Expect with To rule now also checks ExpectWithOffset(); e.g.

    ExpectWithOffset(err).ShouldNot(HaveOccurred())
    // will be changed to:
    ExpectWithOffset(err).ToNot(HaveOccurred())
  • Bump go to v1.22

  • [internal] Huge Refactoring

    • separate parsing and processing from validation
    • introduce gomega expression Rules

Full Changelog: nunnatsa/ginkgolinter@v0.16.2...v0.17.0

Commits
  • 7c3d5e2 Bump golang.org/x/tools from 0.25.0 to 0.26.0
  • 96291f1 encapsulate the GomegaExpression fields
  • 0612576 [Refactor] introduce gomega expression Rules
  • 4ea414a [Refactoring] refactor the no-assertion rule
  • d12af21 cosmetic fixes in sanity tests
  • 2b72ad1 update e2e tests
  • ceaac84 stop using the deprecated ast.Object and ast.Ident.Obj
  • 9081c3f use the new GomegaExpression type
  • 1a3a960 Introduce GomegaExpression type
  • 3e975b3 bump dependencies
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/nunnatsa/ginkgolinter](https://github.com/nunnatsa/ginkgolinter) from 0.16.2 to 0.17.0.
- [Release notes](https://github.com/nunnatsa/ginkgolinter/releases)
- [Commits](nunnatsa/ginkgolinter@v0.16.2...v0.17.0)

---
updated-dependencies:
- dependency-name: github.com/nunnatsa/ginkgolinter
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Relates to an upstream dependency go Pull requests that update Go code labels Oct 29, 2024
@ldez ldez added the linter: update version Update version of linter label Oct 29, 2024
@ldez ldez added this to the next milestone Oct 29, 2024
@ldez ldez self-requested a review October 29, 2024 15:04
@ldez ldez merged commit ce9bbe3 into master Oct 29, 2024
15 checks passed
@ldez ldez deleted the dependabot/go_modules/github.com/nunnatsa/ginkgolinter-0.17.0 branch October 29, 2024 15:15
@ldez ldez modified the milestones: next, v1.62 Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant