New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: remove unnecessary nil slice check #4883

Closed

alexandear wants to merge 1 commit into golangci:master from alexandear:dev-remove-unnecessary-nil-slice-check

Member

alexandear commented Jul 24, 2024

len(issues) == 0 is true for []result.Issue{} or []result.Issue(nil).

And nil slice is preferable to the empty slice according to the Go Wiki.


          dev: remove unnecessary nil slice check

d34eb65

Member

ldez commented Jul 24, 2024

This is required by JSON serialization.

ldez closed this

ldez added the declined label

alexandear mentioned this pull request

dev: add comment to clarify using empty issues slice #4884

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels