Add fparams linter

.golangci.reference.yml

@@ -427,6 +427,15 @@ linters-settings:
     # Default: false
     analyze-types: true
 
+  fparams:
+    # Disable check function params
+    # Default: false
+    disableCheckFuncParams: false
+
+    # Disable check function return values
+    # Default false
+    disableCheckFuncReturns: false
+
   funlen:
     # Checks the number of lines in a function.
     # If lower than 0, disable the check.
@@ -2593,6 +2602,7 @@ linters:
     - fatcontext
     - forbidigo
     - forcetypeassert
+    - fparams
     - funlen
     - gci
     - ginkgolinter
@@ -2708,6 +2718,7 @@ linters:
     - fatcontext
     - forbidigo
     - forcetypeassert
+    - fparams
     - funlen
     - gci
     - ginkgolinter

go.mod

@@ -1,6 +1,8 @@
 module github.com/golangci/golangci-lint
 
-go 1.21.0
+go 1.22
+
+toolchain go1.22.4
 
 require (
 	4d63.com/gocheckcompilerdirectives v1.2.1
@@ -19,6 +21,7 @@ require (
 	github.com/alexkohler/nakedret/v2 v2.0.4
 	github.com/alexkohler/prealloc v1.0.0
 	github.com/alingse/asasalint v0.0.11
+	github.com/artemk1337/fparams v1.0.0
 	github.com/ashanbrown/forbidigo v1.6.0
 	github.com/ashanbrown/makezero v1.1.1
 	github.com/bkielbasa/cyclop v1.2.1

pkg/config/linters_settings.go

@@ -212,6 +212,7 @@ type LintersSettings struct {
 	Exhaustive      ExhaustiveSettings
 	Exhaustruct     ExhaustructSettings
 	Forbidigo       ForbidigoSettings
+	Fparams         Fparams
 	Funlen          FunlenSettings
 	Gci             GciSettings
 	GinkgoLinter    GinkgoLinterSettings
@@ -455,6 +456,11 @@ func (p *ForbidigoPattern) MarshalString() ([]byte, error) {
 	return yaml.Marshal(p)
 }
 
+type Fparams struct {
+	DisableCheckFuncParams  bool `mapstructure:"disable-check-params"`
+	DisableCheckFuncReturns bool `mapstructure:"disable-check-returns"`
+}
+
 type FunlenSettings struct {
 	Lines          int
 	Statements     int

pkg/golinters/fparams/fparams.go

@@ -0,0 +1,28 @@
+package fparams
+
+import (
+	"github.com/artemk1337/fparams/pkg/analyzer"
+	"github.com/golangci/golangci-lint/pkg/config"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/goanalysis"
+)
+
+func New(settings *config.Fparams) *goanalysis.Linter {
+	a := analyzer.NewAnalyzer()
+
+	cfg := map[string]map[string]any{}
+	if settings != nil {
+		cfg[a.Name] = map[string]any{
+			"disableCheckFuncParams":  settings.DisableCheckFuncParams,
+			"disableCheckFuncReturns": settings.DisableCheckFuncReturns,
+		}
+	}
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/fparams/fparams_integration_test.go

@@ -0,0 +1,11 @@
+package fparams
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/fparams/testdata/fix/in/fparams.go

@@ -0,0 +1,74 @@
+//golangcitest:args -Efparams
+//golangcitest:expected_exitcode 0
+package fparams
+
+func invalidArgsFuncA(a int,
+	b string) {
+	return
+}
+
+func invalidArgsFuncB(a, b int,
+	c string) {
+	return
+}
+
+func invalidArgsFuncC(a,
+	b int,
+	c string,
+) {
+	return
+}
+
+func invalidArgsFuncD(
+	a, b int,
+	c string,
+) {
+	return
+}
+
+func invalidArgsAndResultsFuncA(a int,
+	b string) (c bool,
+	d error) {
+	return false, nil
+}
+
+func invalidArgsAndResultsFuncB(a int, b int,
+	c string) (
+	d bool,
+	e error) {
+	return false, nil
+}
+
+func invalidResultsFuncA() (a bool,
+	b error) {
+	return false, nil
+}
+
+func invalidResultsFuncB() (
+	a bool,
+	b error) {
+	return false, nil
+}
+
+func invalidResultsFuncC() (
+	a bool, b error) {
+	return false, nil
+}
+
+func invalidResultsFuncD() (
+	a, b bool,
+	c error) {
+	return false, false, nil
+}
+
+func invalidResultsFuncE() (bool, bool,
+	error) {
+	return false, false, nil
+}
+
+func invalidResultsFuncF() (
+	bool,
+	bool,
+	error) {
+	return false, false, nil
+}

pkg/golinters/fparams/testdata/fix/out/fparams.go

@@ -0,0 +1,100 @@
+//golangcitest:args -Efparams
+//golangcitest:expected_exitcode 0
+package fparams
+
+func invalidArgsFuncA(
+	a int,
+	b string,
+) {
+	return
+}
+
+func invalidArgsFuncB(
+	a int,
+	b int,
+	c string,
+) {
+	return
+}
+
+func invalidArgsFuncC(
+	a int,
+	b int,
+	c string,
+) {
+	return
+}
+
+func invalidArgsFuncD(
+	a int,
+	b int,
+	c string,
+) {
+	return
+}
+
+func invalidArgsAndResultsFuncA(
+	a int,
+	b string,
+) (
+	c bool,
+	d error,
+) {
+	return false, nil
+}
+
+func invalidArgsAndResultsFuncB(
+	a int,
+	b int,
+	c string,
+) (
+	d bool,
+	e error,
+) {
+	return false, nil
+}
+
+func invalidResultsFuncA() (
+	a bool,
+	b error,
+) {
+	return false, nil
+}
+
+func invalidResultsFuncB() (
+	a bool,
+	b error,
+) {
+	return false, nil
+}
+
+func invalidResultsFuncC() (
+	a bool,
+	b error,
+) {
+	return false, nil
+}
+
+func invalidResultsFuncD() (
+	a bool,
+	b bool,
+	c error,
+) {
+	return false, false, nil
+}
+
+func invalidResultsFuncE() (
+	bool,
+	bool,
+	error,
+) {
+	return false, false, nil
+}
+
+func invalidResultsFuncF() (
+	bool,
+	bool,
+	error,
+) {
+	return false, false, nil
+}