build(deps): bump github.com/daixiang0/gci from 0.12.3 to 0.13.3 #4522
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
ldez
added
blocked
|
Blocked because this will never work as expected with golangci-lint. I created, a few months ago, https://github.com/golangci/modinfo to handle this kind of problem, I think that gci should use it. Also, all the existing linters that need the module information use the same approach (it's also the same as https://github.com/golangci/modinfo) because it's the more reliable solution and recommended by the Go team. Related to #4484 |
|
How easy is the change? I could try to give it a go this week so we can get support for gci in golangci-lint, but could use some pointers of an example implementation / how to get started from @ldez 🙏🏼 |
The design of gci has been over-designed, so maybe or maybe not.
You can find examples inside the doc: https://github.com/golangci/modinfo?tab=readme-ov-file#examples |
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/daixiang0/gci-0.13.1
branch
from
5b6408f to
0426420
Compare
Bumps [github.com/daixiang0/gci](https://github.com/daixiang0/gci) from 0.12.3 to 0.13.1. - [Release notes](https://github.com/daixiang0/gci/releases) - [Commits](daixiang0/gci@v0.12.3...v0.13.1) --- updated-dependencies: - dependency-name: github.com/daixiang0/gci dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
ldez
force-pushed
the
dependabot/go_modules/github.com/daixiang0/gci-0.13.1
branch
from
0426420 to
27121d0
Compare
|
@ldez thanks for your nice help! https://github.com/daixiang0/gci/releases/tag/v0.13.2 should fix it. |
ldez
changed the title
|
FYI v0.13.2 doesn't fix the problem, but it's not important because my current hack fixes the problem. |
|
I can confirm that your branch of golangci-lint works with the latest gci that supports localmodule, thank you so much @ldez 🎉 |
ldez
changed the title
ldez
deleted the
dependabot/go_modules/github.com/daixiang0/gci-0.13.1
branch
Bumps github.com/daixiang0/gci from 0.12.3 to 0.13.3.
See full diff in compare view
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)