dev: clean up Executor #4404
Merged
dev: clean up Executor #4404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
topic: cleanup
This comment was marked as outdated.
This comment was marked as outdated.
Since the presets are not linked to the Executor, this first call is useless.
ldez
force-pushed
the
feat/rewrite-executor-part1
branch
from
4e28961 to
33416b2
Compare
bombsimon
approved these changes
Feb 21, 2024
This was referenced Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of the rewrite of the command line (the
Executor).I split the changes into several PRs to ease the review.
This PR mainly moves, organizes, and splits the current code.
There are no major changes, but I spent a lot of time analyzing the code to be able to make the right changes to prepare for the new step.
I also removed all the deprecated flags.
They have been deprecated for multiple years (2018), so it is safe to remove them.
I made small commits to ease the review: each commit contains one change.
I recommend reviewing each commit first instead of the full change because it's easier to follow changes.
I already have the next PR, but this PR must be merged first.
related to #4397 (comment)
FYI with changes inside this PR, I can just move one line to fix the problem related to the configuration loading, but this will not fix the core of the problem: the maintainability of the code.
Also, this PR improves a bit the performance by removing one of the multiple builds of the linters (I will also fix that in another PR).
EDIT: --update-refs is the best rebase option ever!