-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.golangci.reference.yml: depguard notice #4227
Conversation
Hey, thank you for opening your first Pull Request ! |
|
@CLAassistant I refuse to sign a CLA which:
I can happily provide a Developer Certificate of Origin (DCO), stating that: (a) The contribution was created in whole or in part by me and I (b) The contribution is based upon previous work that, to the best (c) The contribution was provided directly to me by some other (d) I understand and agree that this project and the contribution (The "Free Software license" being GPL-3.0) Anyway I believe such a minor change is not covered by copyright (nothing original here). |
To sign the CLA is required. Anyway, the change of this PR talks about something not supported by our configuration: |
For details, please check out this [PR](golangci/golangci-lint#4227). Signed-off-by: Yann Liu <[email protected]>
* Update deps Signed-off-by: Yann Liu <[email protected]> * Update API groups Signed-off-by: Yann Liu <[email protected]> * Run make gen Signed-off-by: Yann Liu <[email protected]> * Use the same version gateway-api as in upstream 1.20 Signed-off-by: Yann Liu <[email protected]> * Update openshift packages Signed-off-by: Yann Liu <[email protected]> * Use the same istio client-go as in the upstream 1.20 Signed-off-by: Yann Liu <[email protected]> * Update depguard configuration as a golangci limitation For details, please check out this [PR](golangci/golangci-lint#4227). Signed-off-by: Yann Liu <[email protected]> --------- Signed-off-by: Yann Liu <[email protected]>
When using
depguard
, special care must be taken to adjust the "Deny" key, otherwise a panic happens:OpenPeeDeeP/depguard#74