Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: add doc about internal package extracted from Go #3204

Merged
merged 5 commits into from
Sep 12, 2022
Merged

dev: add doc about internal package extracted from Go #3204

merged 5 commits into from
Sep 12, 2022

Conversation

ldez
Copy link
Member

@ldez ldez commented Sep 11, 2022 •
edited
Loading

  • add some readme
  • update robustio
  • add comments on skip-dirs
  • fix flaky tests on Windows and Darwin

@ldez ldez added enhancement New feature or improvement area: docs topic: cleanup Related to code, process, or doc cleanup labels Sep 11, 2022
@ldez ldez force-pushed the feat/doc-internal branch from 9aa51a9 to ade6924 Compare September 11, 2022 11:00
@ldez ldez force-pushed the feat/doc-internal branch from ade6924 to 54c5e78 Compare September 11, 2022 12:52
@ldez ldez force-pushed the feat/doc-internal branch from 54c5e78 to 51d72be Compare September 11, 2022 12:55
@ldez ldez mentioned this pull request Sep 11, 2022
Merged
@ldez ldez requested a review from bombsimon September 12, 2022 07:01
bombsimon
bombsimon approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice readmes with the history. Although we might risk updating this in future changes it's easy enough to do that retroactively at any time like you did now. 👍

@ldez ldez merged commit f072d55 into golangci:master Sep 12, 2022
@ldez ldez deleted the feat/doc-internal branch September 12, 2022 07:19
@ldez
Copy link
Member Author

ldez commented Sep 12, 2022

The update of some packages will be really complex (I tried) because we don't have a clear starting point.
At some point, we will have to re-think those packages.

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
dev: add doc about internal package extracted from Go (golangci#3204)
8103f30
@ldez ldez added this to the v1.50 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: docs enhancement New feature or improvement topic: cleanup Related to code, process, or doc cleanup
Projects
None yet
Milestone
v1.50
Development

Successfully merging this pull request may close these issues.
2 participants
@ldez @bombsimon