-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github.com/timonwong/logrlint from 0.1.0 to 0.4.0 #3140
Conversation
Signed-off-by: Timon Wong <[email protected]>
c2de8ef
to
5faffb8
Compare
FYI in the basic case, when a linter requires an update we let the dependabot handle that. |
I would like to propose a better configuration: linters-settings:
logrlint:
logr: true
klog: true
zap: true
|
Why your PR is on draft? |
@ldez It's still working in progress right now |
It's better to open a PR when the PR is ready because with a draft PR:
When you open a draft PR, you must be clear on why and also explain what are the missing parts or the WIP. |
Also, your linter name is based on I think it can be better to create another linter with a better name that fits with the goal of your linter, and deprecate the previous linter. |
Thanks, I'll close this PR for now. When it's ready, I'll open a new PR for review |
timonwong/logrlint@v0.1.0...v0.3.0
Notable changes:
disableall
,disable
andenable