Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump importas to HEAD #1899

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Bump importas to HEAD #1899

merged 2 commits into from
Apr 6, 2021

Conversation

sachaos
Copy link
Member

@sachaos sachaos commented Apr 5, 2021

  • Update importas version
  • Add new feature's example to .golangci.example.yml
    • importas supports regular expression now.

@boring-cyborg
Copy link

boring-cyborg bot commented Apr 5, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sachaos sachaos mentioned this pull request Apr 5, 2021
Merged
@ldez
Copy link
Member

ldez commented Apr 5, 2021 •
edited
Loading

Hello, we will wait for a tagged version.
ping @julz

Edit: it was already a pseudo version.

@ldez ldez added blocked Need's direct action from maintainer linter: update version Update version of linter and removed blocked Need's direct action from maintainer labels Apr 5, 2021
ldez
ldez approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit c5891c0 into golangci:master Apr 6, 2021
@golangci-automator
Copy link

Hey, @sachaos — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@sachaos sachaos deleted the feat/update-importas branch April 6, 2021 02:59
@ldez ldez added this to the v1.40 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
linter: update version Update version of linter
Projects
None yet
Milestone
v1.40
Development

Successfully merging this pull request may close these issues.
3 participants
@sachaos @CLAassistant @ldez