Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releasing docker image for arm64 #1383

Merged
merged 2 commits into from
Oct 18, 2020
Merged

Releasing docker image for arm64 #1383

merged 2 commits into from
Oct 18, 2020

Conversation

odidev
Copy link
Contributor

@odidev odidev commented Sep 21, 2020 •
edited
Loading

Updated below files:

  1. Updated .github/workflows/tag.yml file to release the image for amd64 and arm64 using https://github.com/docker/build-push-action.
  2. Updated build/Dockerfile and build/Dockerfile.alpine files to build the golangci-lint binary from the source code and copy that binary to /usr/bin/ using multi-stage docker build.
  3. Removed the docker file section from .goreleaser.yml as goreleaser does not support multi-arch builds currently.

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 21, 2020

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@odidev odidev mentioned this pull request Sep 21, 2020
Closed
sayboras
sayboras reviewed Sep 21, 2020
View reviewed changes
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile.alpine Show resolved Hide resolved
.github/workflows/tag.yml Show resolved Hide resolved
@odidev
Copy link
Contributor Author

odidev commented Sep 21, 2020

@sayboras I have addressed the comment.

sayboras
sayboras reviewed Sep 22, 2020
View reviewed changes
build/Dockerfile.alpine Outdated Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
build/Dockerfile.alpine Show resolved Hide resolved
build/Dockerfile Outdated Show resolved Hide resolved
sayboras
sayboras reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments for Dockerfile. Can you also update PR description? Having good commit mesage will definitely help for other to review as well.

@odidev odidev force-pushed the golangci-lint_arm64_support branch from 6020162 to 4c808f9 Compare September 25, 2020 05:30
@sayboras
Copy link
Member

I think this PR is in better shape now, you can rebase with master and mark it ready for review.

@odidev odidev force-pushed the golangci-lint_arm64_support branch from 4c808f9 to 84bf68f Compare September 28, 2020 11:22
@odidev odidev marked this pull request as ready for review September 28, 2020 11:27
@sayboras sayboras requested a review from a team September 28, 2020 11:36
sayboras
sayboras approved these changes Oct 2, 2020
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

LGTM based on the asumption that we will need to remove docker in goreleaser. One implication of such removal is that generated release docs will not have docker details. I am completely ok with it as https://golangci-lint.run/usage/install/ website is having step on how to run with docker.

/cc @golangci/team @golangci/core-team

@sayboras sayboras requested review from a team October 2, 2020 12:02
@sayboras
Copy link
Member

Seems like there is no more comment, I am merging this PR 💯

@sayboras sayboras merged commit 3368a55 into golangci:master Oct 18, 2020
@golangci-automator
Copy link

Hey, @odidev — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

@odidev
Copy link
Contributor Author

odidev commented Oct 19, 2020

Thanks for the merge. May I know when are you planning on releasing/uploading arm64 docker images?

@sayboras
Copy link
Member

Thanks for the merge. May I know when are you planning on releasing/uploading arm64 docker images?

Prepared PR #1456 was merged, maybe sometime this week for new release, this will be first time we test new docker build as well.

sayboras added a commit to sayboras/golangci-lint that referenced this pull request Oct 26, 2020
@sayboras
build(docker): Fix version details in docker image
06fa9d5 
As part of golangci#1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags
as part of Docker build.

Fixes golangci#1468

Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Oct 26, 2020
Closed
sayboras added a commit to sayboras/golangci-lint that referenced this pull request Oct 26, 2020
@sayboras
build(docker): Fix version details in docker image
bb9fbeb 
As part of golangci#1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags
as part of Docker build.

Fixes golangci#1468

Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to sayboras/golangci-lint that referenced this pull request Oct 26, 2020
@sayboras
build(docker): Fix version details in docker image
af681a2 
As part of golangci#1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags
as part of Docker build.

Fixes golangci#1468

Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to sayboras/golangci-lint that referenced this pull request Oct 26, 2020
@sayboras
build(docker): Fix version details in docker image
9744e3a 
As part of golangci#1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags
as part of Docker build.

Fixes golangci#1468

Signed-off-by: Tam Mach <[email protected]>
sayboras added a commit to sayboras/golangci-lint that referenced this pull request Oct 26, 2020
@sayboras
build(docker): Fix version details in docker image
e807ce3 
As part of golangci#1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags as part of Docker build.

Fixes golangci#1468

Signed-off-by: Tam Mach <[email protected]>
@sayboras sayboras mentioned this pull request Oct 26, 2020
Merged
sayboras added a commit that referenced this pull request Oct 27, 2020
@sayboras
build(docker): Fix version details in docker image (#1471)
dc2d6b5 
* build(docker): Fix version details in docker image

As part of #1383, multi-arch docker build was supported. However,
ldflags for version details was missing.

This commit is to add -ldflags as part of Docker build. I take this chance
to refactor github action as well.

Fixes #1468

Signed-off-by: Tam Mach <[email protected]>
@ldez ldez added this to the v1.32 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area: docker enhancement New feature or improvement
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@odidev @CLAassistant @sayboras @ldez