Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing Travis with Github actions #1056

Merged
merged 6 commits into from
May 3, 2020
Merged

Replacing Travis with Github actions #1056

merged 6 commits into from
May 3, 2020

Conversation

iwankgb
Copy link
Contributor

@iwankgb iwankgb commented May 1, 2020 •
edited
Loading

Important notes:

  • I had to update go.mod and go.sum in tools/ - I wasn't able to run make generate otherwise
  • goreleaser does not support gomips key in the configuration
  • I got rid of time in Makefile to support builds on Windows.

I decided to extend builds to Windows and MacOS but:

  • tests on Windows fail miserably
  • tests on MacOS timeout on Go 1.14 (sometimes)

Release build was tested for Docker and Github releases. I was not able to test Homebrew. Secrets must be set for hub.docker.com (GOLANGCI_LINT_DOCKER_TOKEN) and Github (GOLANGCI_LINT_TOKEN) authentication

Fixes #1039, supersedes #1054

iwankgb added 2 commits May 1, 2020 18:47
@iwankgb
An attempt to run make generate
1ae70ed 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb
Running build using Github Actions
9b4002e 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb
Copy link
Contributor Author

iwankgb commented May 1, 2020

@ernado you may need to check some configuration options for the repository to enable Github Actions.

@iwankgb iwankgb marked this pull request as draft May 1, 2020 19:01
@iwankgb iwankgb changed the title Replacing Travis with Github actions WIP: Replacing Travis with Github actions May 1, 2020
@iwankgb iwankgb changed the title WIP: Replacing Travis with Github actions Replacing Travis with Github actions May 1, 2020
@iwankgb iwankgb force-pushed the github_actions branch 2 times, most recently from cc5788b to eab0ca1 Compare May 1, 2020 20:12
@iwankgb
Adding deploy build for tags
4b0ab63 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb iwankgb marked this pull request as ready for review May 1, 2020 20:18
iwankgb added 3 commits May 1, 2020 22:33
@iwankgb
Removing Travis configuration
6f36a5f 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb
Removing hardcoded version string
ab9d241 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@iwankgb
We can use non-fast generated check
0129164 
Signed-off-by: Maciej "Iwan" Iwanowski <[email protected]>
@ernado
Copy link
Member

ernado commented May 2, 2020

Oh, great job!

Can you please leave Travis for deploy script?
We are running goreleaser on version tag and I'm not sure that porting to actions is trivial.

@iwankgb
Copy link
Contributor Author

iwankgb commented May 2, 2020

I have already ported and tested it - see PR description.

@ernado
Copy link
Member

ernado commented May 2, 2020

Oh, now I see.

@jirfag PTAL, seems like we should add secrets in settings.
https://help.github.com/en/actions/configuring-and-managing-workflows/creating-and-storing-encrypted-secrets

@iwankgb
Copy link
Contributor Author

iwankgb commented May 2, 2020

There will be one more for Homebrew but I have no experience with the tool and I have no idea how to authenticate.

jirfag
jirfag approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@jirfag jirfag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thank you!
I've added all GitHub secrets, so we can merge it

.github/workflows/pr.yml
strategy:
matrix:
golang:
- 1.12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove 1.12 please to speed up CI like in #1060 . And the same for unix

.goreleaser.yml
@@ -25,8 +25,6 @@ builds:
goarm:
- 6
- 7
gomips:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's wrong with that?

@jirfag
Copy link
Member

jirfag commented May 3, 2020

I can fix and check brew myself

@jirfag jirfag merged commit 77e211b into golangci:master May 3, 2020
@ldez ldez added the area: ci PR that update CI label Dec 7, 2020
@ldez ldez mentioned this pull request Feb 6, 2021
Merged
@ldez ldez mentioned this pull request Aug 24, 2022
Merged
@ldez ldez added this to the v1.27 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirfag jirfag jirfag approved these changes

Assignees
No one assigned
Labels
area: ci PR that update CI
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

dev: use github actions
4 participants
@iwankgb @ernado @jirfag @ldez