Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nolint comments matching #68

Closed
jakubtomany opened this issue Jun 5, 2018 · 1 comment
Closed

Improve nolint comments matching #68

jakubtomany opened this issue Jun 5, 2018 · 1 comment
Labels
area: nolint Related to nolint directive and nolintlint enhancement New feature or improvement

Comments

@jakubtomany
Copy link

Match nolint comments:

  • on a line above the problematic code
  • on a line above the function definition containing the problematic code
  • if there are spaces in comment between nolint: and linters list
@jirfag jirfag added the enhancement New feature or improvement label Jun 6, 2018
@jirfag
Copy link
Member

jirfag commented Jun 6, 2018

thank you for the issue, it's a duplicate of #65, let's continue in it

@jirfag jirfag closed this as completed Jun 6, 2018
golangci pushed a commit that referenced this issue Jun 6, 2018
@jirfag
#65, #68: make //nolint processing like in gometalinter
8a9b3a5
jirfag added a commit that referenced this issue Jun 6, 2018
@jirfag
Merge pull request #71 from golangci/feature/full-support-of-nolint-d…
110f584 
…irectives

#65, #68: make //nolint processing like in gometalinter
@ldez ldez added the area: nolint Related to nolint directive and nolintlint label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: nolint Related to nolint directive and nolintlint enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jirfag @ldez @jakubtomany