-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use upstream ineffassign instead of golangci fork
- Loading branch information
Sergey Vilgelm
committed
Feb 25, 2021
1 parent
b77118f
commit 795077e
Showing
4 changed files
with
8 additions
and
52 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,61 +1,17 @@ | ||
| package golinters | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "sync" | ||
|
|
||
| "github.com/golangci/ineffassign" | ||
| "github.com/gordonklaus/ineffassign/pkg/ineffassign" | ||
| "golang.org/x/tools/go/analysis" | ||
|
|
||
| "github.com/golangci/golangci-lint/pkg/golinters/goanalysis" | ||
| "github.com/golangci/golangci-lint/pkg/lint/linter" | ||
| "github.com/golangci/golangci-lint/pkg/result" | ||
| ) | ||
|
|
||
| const ineffassignName = "ineffassign" | ||
|
|
||
| func NewIneffassign() *goanalysis.Linter { | ||
| var mu sync.Mutex | ||
| var resIssues []goanalysis.Issue | ||
|
|
||
| analyzer := &analysis.Analyzer{ | ||
| Name: ineffassignName, | ||
| Doc: goanalysis.TheOnlyanalyzerDoc, | ||
| } | ||
| return goanalysis.NewLinter( | ||
| ineffassignName, | ||
| "ineffassign", | ||
| "Detects when assignments to existing variables are not used", | ||
| []*analysis.Analyzer{analyzer}, | ||
| []*analysis.Analyzer{ineffassign.Analyzer}, | ||
| nil, | ||
| ).WithContextSetter(func(lintCtx *linter.Context) { | ||
| analyzer.Run = func(pass *analysis.Pass) (interface{}, error) { | ||
| var fileNames []string | ||
| for _, f := range pass.Files { | ||
| pos := pass.Fset.PositionFor(f.Pos(), false) | ||
| fileNames = append(fileNames, pos.Filename) | ||
| } | ||
|
|
||
| issues := ineffassign.Run(fileNames) | ||
| if len(issues) == 0 { | ||
| return nil, nil | ||
| } | ||
|
|
||
| res := make([]goanalysis.Issue, 0, len(issues)) | ||
| for _, i := range issues { | ||
| res = append(res, goanalysis.NewIssue(&result.Issue{ | ||
| Pos: i.Pos, | ||
| Text: fmt.Sprintf("ineffectual assignment to %s", formatCode(i.IdentName, lintCtx.Cfg)), | ||
| FromLinter: ineffassignName, | ||
| }, pass)) | ||
| } | ||
|
|
||
| mu.Lock() | ||
| resIssues = append(resIssues, res...) | ||
| mu.Unlock() | ||
|
|
||
| return nil, nil | ||
| } | ||
| }).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue { | ||
| return resIssues | ||
| }).WithLoadMode(goanalysis.LoadModeSyntax) | ||
| ).WithLoadMode(goanalysis.LoadModeTypesInfo) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters