Skip to content

Commit

Permalink
internal/genericosv: skip failing test pending fix
Browse files Browse the repository at this point in the history
The test TestToReport is failing because it is making real proxy calls,
whose responses may change over time. Skip this test until we can fix it
by using mock proxy calls instead.

Change-Id: Ia7f82c255eb44bf1b98961e430afef6604b8e14a
Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/522295
Run-TryBot: Tatiana Bradley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
  • Loading branch information
tatianab committed Aug 23, 2023
1 parent 809edcc commit 7cfc412
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/genericosv/report_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,11 @@ var (

// To update test cases to reflect new expected behavior:
// go test ./internal/genericosv/... -update -run TestToReport
//
// TODO(https://go.dev/issues/61769): mock out proxy calls in the non-update
// case so that this test is hermetic.
func TestToReport(t *testing.T) {
t.Skip("need to mock out proxy calls")
if err := filepath.WalkDir(testOSVDir, func(path string, f fs.DirEntry, err error) error {
if err != nil {
return err
Expand Down

0 comments on commit 7cfc412

Please sign in to comment.