Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart language server automatically instead of asking user to reload #3

Closed
wants to merge 3 commits into from
Closed

Conversation

stamblerre
Copy link
Contributor

@stamblerre stamblerre commented Mar 6, 2020

Minimize the number of instances where we ask the user to reload their VS Code window.
There are still a few more places where this command could be improved.

Updates microsoft/vscode-go#2607.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 6, 2020
@gopherbot
Copy link
Collaborator

This PR (HEAD: 95c38f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/222418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: 5bc3c1a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/222418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

This PR (HEAD: 125fb19) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/222418 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Hyang-Ah Hana Kim:

Patch Set 4:

(3 comments)

fyi the ci run succeeded (https://github.com/golang/vscode-go/pull/3/checks?check_run_id=502206526)


Please don’t reply on this GitHub thread. Visit golang.org/cl/222418.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants