Skip to content

Commit

Permalink
[release] goTools: don't fail gocode installation if gocode is not al…
Browse files Browse the repository at this point in the history
…ready running

Fixes #355
Fixes #362

Change-Id: Ifdf229ce52a6a4b1a2e4f0a28ac5596405ff4c56
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/242780
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
(cherry picked from commit db1d1b3)
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/243898
Reviewed-by: Rebecca Stambler <[email protected]>
  • Loading branch information
stamblerre authored and hyangah committed Jul 21, 2020
1 parent a6c4f17 commit 6fad3bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/goTools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export const allToolsInformation: { [key: string]: Tool } = {
return `Installing gocode aborted as existing process cannot be closed. Please kill the running process for gocode and try again.`;
}
} catch (err) {
return `Failed to close gocode process: ${err}.`;
// This may fail if gocode isn't already running.
}
return '';
},
Expand Down

0 comments on commit 6fad3bc

Please sign in to comment.