Skip to content

Commit

Permalink
Make additionalProperties false for object type settings
Browse files Browse the repository at this point in the history
I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `"additionalProperties": false` for the objects that don't expect more properties would be great!
  • Loading branch information
9at8 authored Jul 3, 2020
1 parent 2a5fd9e commit 695aa78
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -1394,6 +1394,7 @@
"description": "Gutter style to indicate covered code."
}
},
"additionalProperties": false,
"default": {
"type": "highlight",
"coveredHighlightColor": "rgba(64,128,128,0.5)",
Expand Down Expand Up @@ -1532,6 +1533,7 @@
"description": "If true, the language server will provide clickable Godoc links for import statements."
}
},
"additionalProperties": false,
"default": {
"diagnostics": true,
"documentLink": true
Expand Down Expand Up @@ -1579,6 +1581,7 @@
"description": "If true, enables code lens for running and debugging tests"
}
},
"additionalProperties": false,
"default": {
"references": false,
"runtest": true
Expand Down Expand Up @@ -1614,6 +1617,7 @@
"description": "Transformation rule used by Go: Add Tags command to add tags"
}
},
"additionalProperties": false,
"default": {
"tags": "json",
"options": "json=omitempty",
Expand All @@ -1637,6 +1641,7 @@
"description": "The number of milliseconds to delay before execution. Resets with each keystroke."
}
},
"additionalProperties": false,
"default": {
"enabled": false,
"delay": 500
Expand All @@ -1663,6 +1668,7 @@
"description": "Comma separated tag=options pairs to be used by Go: Remove Tags command"
}
},
"additionalProperties": false,
"default": {
"tags": "",
"options": "",
Expand Down Expand Up @@ -1691,6 +1697,7 @@
},
"description": "The flags configured here will be passed through to command `goplay`"
},
"additionalProperties": false,
"default": {
"openbrowser": true,
"share": true,
Expand Down Expand Up @@ -1771,6 +1778,7 @@
"description": "If true, adds command to debug the test under the cursor to the editor context menu"
}
},
"additionalProperties": false,
"default": {
"toggleTestFile": true,
"addTags": true,
Expand Down Expand Up @@ -1904,7 +1912,8 @@
"default": "guru",
"description": "Alternate tool to use instead of the guru binary or alternate path to use for the guru binary."
}
}
},
"additionalProperties": false
}
}
},
Expand Down

0 comments on commit 695aa78

Please sign in to comment.