Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text: bump x/tools #8

Closed
wants to merge 1 commit into from
Closed

text: bump x/tools #8

wants to merge 1 commit into from

Conversation

carlosedp
Copy link

Signed-off-by: CarlosEDP <[email protected]>
@gopherbot
Copy link
Contributor

This PR (HEAD: faf82a3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/text/+/188777 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Brad Fitzpatrick:

Patch Set 1:

Commit message is a bit weak. Why? I assume something for RISC-V due to the GitHub reference, but what exactly?


Please don’t reply on this GitHub thread. Visit golang.org/cl/188777.
After addressing review feedback, remember to publish your drafts!

@carlosedp
Copy link
Author

I've seen some projects add indirect references to x/tools when using x/text.
x/tools already got it's modules bumped to newer versions that build on Risc-V.

@gopherbot
Copy link
Contributor

Message from Carlos Eduardo de Paula:

Patch Set 1:

Patch Set 1:

Commit message is a bit weak. Why? I assume something for RISC-V due to the GitHub reference, but what exactly?

I've seen some projects add indirect references to x/tools when using x/text.
x/tools already got it's modules bumped to newer versions that build on Risc-V.


Please don’t reply on this GitHub thread. Visit golang.org/cl/188777.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

Commit message is a bit weak. Why? I assume something for RISC-V due to the GitHub reference, but what exactly?

I've seen some projects add indirect references to x/tools when using x/text.
x/tools already got it's modules bumped to newer versions that build on Risc-V.

Can you add some specifics to the description? Thanks.


Please don’t reply on this GitHub thread. Visit golang.org/cl/188777.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Eduardo de Paula:

Patch Set 1:

Patch Set 1:

Commit message is a bit weak. Why? I assume something for RISC-V due to the GitHub reference, but what exactly?

I've seen some projects add indirect references to x/tools when using x/text.
x/tools already got it's modules bumped to newer versions that build on Risc-V.

Can you add some specifics to the description? Thanks.

Sorry, I updated modules for Alertmanager and this got pointed: prometheus/alertmanager#1984.


Please don’t reply on this GitHub thread. Visit golang.org/cl/188777.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Carlos Eduardo de Paula:

Patch Set 1:

My bad, this is not required as the dependencies were on other modules. Big confusion, sorry for the noise.How can I close and abandon this?


Please don’t reply on this GitHub thread. Visit golang.org/cl/188777.
After addressing review feedback, remember to publish your drafts!

@carlosedp carlosedp closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants