unix: fix mkerrors.sh on OpenBSD by using strlcpy #163
Conversation
On OpenBSD, strcpy causes an error message output that recommends the use of strlcpy[0]. Here, the result was that this output became part of the generated program code, causing gofmt to fail and create an empty zerrors_openbsd_GOARCH.go file. An ifdef guard has been added within the C code which uses the desired strlcpy function under OpenBSD. Other operating systems continue to use strcpy. [0] https://github.com/openbsd/src/blob/958bc3ae91838214c6d3bb7efc272663a5df7b01/lib/libc/string/strcpy.c#L34-L37
|
Somehow I have overlooked #147 until I just opened this PR. However, the other PR seems to be stalled and this one introduces no changes for other operating systems. |
|
This PR (HEAD: 8c0f635) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/sys/+/501075 to see it. Tip: You can toggle comments from me using the |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/501075. |
|
Message from Alvar Penning: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/501075. |
|
Message from Ian Lance Taylor: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/501075. |
On OpenBSD, strcpy causes an error message output that recommends the use of strlcpy[0]. Here, the result was that this output became part of the generated program code, causing gofmt to fail and create an empty zerrors_openbsd_GOARCH.go file.
An ifdef guard has been added within the C code which uses the desired strlcpy function under OpenBSD. Other operating systems continue to use strcpy.
[0] https://github.com/openbsd/src/blob/958bc3ae91838214c6d3bb7efc272663a5df7b01/lib/libc/string/strcpy.c#L34-L37