Skip to content

Commit

Permalink
git-codereview: add -autosubmit
Browse files Browse the repository at this point in the history
Add a flag to set the Auto-Submit label.

For golang/go#48021.

Change-Id: If704e8b5e9e0e2521eed78fe28af10d3c31ec3a0
Reviewed-on: https://go-review.googlesource.com/c/review/+/431375
Auto-Submit: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
  • Loading branch information
heschi authored and gopherbot committed Oct 3, 2022
1 parent 0c548b8 commit a897dc9
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
6 changes: 4 additions & 2 deletions git-codereview/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ It is run by the shell scripts installed by the “git codereview hooks” comma
The mail command starts the code review process for the pending change.
git codereview mail [-r email,...] [-cc email,...]
[-diff] [-f] [-hashtag tag,...] [-nokeycheck]
[-topic topic] [-trybot] [-wip]
[-autosubmit] [-diff] [-f] [-hashtag tag,...]
[-nokeycheck] [-topic topic] [-trybot] [-wip]
[revision]
It pushes the pending change commit in the current branch to the Gerrit code
Expand Down Expand Up @@ -257,6 +257,8 @@ is needed is when checking in test cases for cryptography libraries.)
The -trybot flag sets a Run-TryBot+1 vote on any uploaded changes.
The Go project uses this vote to start running integration tests on the CL.
The -autosubmit flag sets a Auto-Submit+1 vote on any uploaded changes.
The -wip flag marks any uploaded changes as work-in-progress.
The mail command updates the tag <branchname>.mailed to refer to the
Expand Down
9 changes: 7 additions & 2 deletions git-codereview/mail.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func cmdMail(args []string) {
trybot = flags.Bool("trybot", false, "run trybots on the uploaded CLs")
wip = flags.Bool("wip", false, "set the status of a change to Work-in-Progress")
noverify = flags.Bool("no-verify", false, "disable presubmits")
autoSubmit = flags.Bool("autosubmit", false, "set autosubmit on the uploaded CLs")
)
flags.Var(rList, "r", "comma-separated list of reviewers")
flags.Var(ccList, "cc", "comma-separated list of people to CC:")
Expand All @@ -35,8 +36,9 @@ func cmdMail(args []string) {
flags.Usage = func() {
fmt.Fprintf(stderr(),
"Usage: %s mail %s [-r reviewer,...] [-cc mail,...]\n"+
"\t[-f] [-diff] [-hashtag tag,...] [-nokeycheck] [-topic topic]\n"+
"\t[-trybot] [-wip] [commit]\n", progName, globalFlags)
"\t[-autosubmit] [-f] [-diff] [-hashtag tag,...]\n"+
"\t[-nokeycheck] [-topic topic] [-trybot] [-wip]\n"+
"\t[commit]\n", progName, globalFlags)
exit(2)
}
flags.Parse(args)
Expand Down Expand Up @@ -147,6 +149,9 @@ func cmdMail(args []string) {
refSpec += start + "wip"
start = ","
}
if *autoSubmit {
refSpec += start + "l=Auto-Submit"
}
args = []string{"push", "-q"}
if *noKeyCheck {
args = append(args, "-o", "nokeycheck")
Expand Down

0 comments on commit a897dc9

Please sign in to comment.