-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsonpb: improve error reporting #310
Conversation
922de2f
to
3cc6773
Compare
Adding error diagnostics sounds fine, but there is no reason to export the error type. Please unexport that. |
3cc6773
to
0c2a563
Compare
I've rebased on latest master, and made the error struct private. @dsnet can you PTAL? |
Hi, thanks for working on this. Apologies for the long delay in reviewing. Can you actually rebase against the |
0c2a563
to
42d8fe0
Compare
@dsnet done, it's now against |
There are some test failures, fix? |
😕
and that's on the |
Would be great if we could finally have this improvement. You could cc @dsnet |
Could also revert, then revert the revert and squash it. I really need this feature as well... |
42d8fe0
to
50f00ee
Compare
rebased on top of latest |
I'm interested in reviving this. @mwitkow, what's the status here? I can jump in. |
See https://github.com/golang/protobuf/tree/api-v2/encoding/protojson If the errors produced by v2 are still insufficient, it'd be good to improve the errors there. |
I haven't looked at the v2 errors yet, I'm not sure. I just got here from twitchtv/twirp#148, through #266. Is there a master issue for v2, or a targeted release date that I can track against? |
The closest thing to a "master" issue is #364, which was the primary reason for a v2. There is no official release date, but we've been aspirationally trying to target a release by GopherCon 2019 (i.e., end of July). I say aspirational because there's still a number items to address. |
Closing as this is unlikely relevant in light of the v2 re-write. |
This PR addresses the issue of:
#266
See the added test for the modification in error handling