Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaby: template de-duplication and UI fixes #55

Open
1 task
tatianab opened this issue Nov 19, 2024 · 2 comments
Open
1 task

gaby: template de-duplication and UI fixes #55

tatianab opened this issue Nov 19, 2024 · 2 comments
Assignees
@tatianab

Comments

@tatianab
Copy link
Contributor

Unify common templates where possible.

UI fixes:

  • remove old result box when a new query is made
@tatianab tatianab self-assigned this Nov 19, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/626535 mentions this issue: internal/gaby: refactor templates and pages

gopherbot pushed a commit that referenced this issue Nov 19, 2024
@tatianab
internal/gaby: refactor templates and pages
918aa14 
Introduce a Go type, [CommonPage], which holds data common to
many Gaby pages, and define common templates on this type.

The goals are 1) to reduce duplication in template files and 2) to move as
much content as possible out of templates and into Go code.

Updates #55

Change-Id: I882ee4b2ba097de05c6466fb08f10c1bfe79393a
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/626535
Reviewed-by: Jonathan Amsterdam <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/631655 mentions this issue: internal/gaby: clear old result when new query is made

gopherbot pushed a commit that referenced this issue Nov 25, 2024
@tatianab @gopherbot
internal/gaby: clear old result when new query is made
a9be3a3 
Clear old results/errors on submit of a new query for the Gaby
webpages.

Updates #55

Change-Id: Iaa2662a7c7fd11b14ebcd661494ee6ed1c6cf617
Reviewed-on: https://go-review.googlesource.com/c/oscar/+/631655
Reviewed-by: Jonathan Amsterdam <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Auto-Submit: Tatiana Bradley <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tatianab tatianab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tatianab @gopherbot