Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google: Add support for OAuth2 token exchange over mTLS #630

Closed
wants to merge 24 commits into from
Closed

google: Add support for OAuth2 token exchange over mTLS #630

wants to merge 24 commits into from

Conversation

andyrzhao
Copy link
Contributor

@andyrzhao andyrzhao commented Feb 22, 2023 •
edited
Loading

With Context Aware Access enabled, users must use the endpoint "https://oauth2.mtls.googleapis.com/token" for token exchange. This PR adds support for runtime configuration of the OAuth2 token endpoint (as determined by the caller). If using the mTLS oauth2 endpoint, the caller will also need to specify an mTLS-enabled HTTPClient via the "context" mechanism for use by the OAuth2 transport.

andyrzhao added 22 commits May 5, 2020 16:55
@andyrzhao
google: Add support for 3-legged-OAuth using OAuth Client ID
ceaa866 
Add OAuthClientTokenSource in google/google.go
Add DefaultAuthorizationHandler in authhandler.go
@andyrzhao
google: Make state configurable in DefaultAuthorizationHandler
04f020b
@andyrzhao
authhandler: Add support for 3-legged-OAuth
1105999 
Added authhandler.go, which implements a TokenSource
to support "three-legged OAuth 2.0" via a custom
AuthorizationHandler.

Added default_authhandler.go to provide a command line
implementation for AuthorizationHandler.
@andyrzhao
authhandler: Add authhandler_test.go
cde11fb
@andyrzhao
authhandler: Update default_authhandler.go to inline handler logic
7c28922
@andyrzhao
authhandler: Rename to CmdAuthorizationHandler and add example_test.go
8a926e1
@andyrzhao
authhandler: Make authHandler the last parameter
ab12fee
@andyrzhao
authhandler: Remove CmdAuthorizationHandler and use it as example ins…
fcaf078 
…tead
@andyrzhao
authhandler: Reword comment regarding state
1ae3746
@andyrzhao
authhandler: Reword comment regarding state in example
48fc036
@andyrzhao
authhandler: Remove example_test.go
ca291c5
@andyrzhao
Merge pull request #1 from golang/master
89bf8af 
Sync from upstream
@andyrzhao
authhandler: Remove example_test.go
baf4632
@andyrzhao
google: Add support for TokenSourceParams, Client ID json, and JWT Su…
9b7db16 
…bject
@andyrzhao
Merge pull request #2 from golang/master
debdcb4 
Sync with upstream master
@andyrzhao
google: Address comments for CredentialsParams support
3a734b4
@andyrzhao
google: Address additional comments for CredentialsParams support.
eb92ab4
@andyrzhao
Merge remote-tracking branch 'upstream/master'
0127caf
@andyrzhao
authhandler: Add support for PKCE
0d1849c
@andyrzhao
authhandler: Address comments for PKCE
c1fddd2
@andyrzhao
Merge branch 'golang:master' into master
df3362d
@andyrzhao
google: Add support for OAuth2 token exchange over mTLS
d171fca
@gopherbot
Copy link
Contributor

This PR (HEAD: d171fca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Shin Fan:

Patch Set 1: Code-Review+2 Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 1: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: a1f84d6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Matt Hickford:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 2: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 3: -Code-Review

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 07e4849) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/470396 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Andy Zhao:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Shin Fan:

Patch Set 4: Code-Review+2 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Matthew Hickford:

Patch Set 4: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/470396.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Mar 3, 2023
@andyrzhao @shinfan
google: Add support for OAuth2 token exchange over mTLS
885f294 
With Context Aware Access enabled, users must use the endpoint "https://oauth2.mtls.googleapis.com/token" for token exchange. This PR adds support for runtime configuration of the OAuth2 token endpoint (as determined by the caller). If using the mTLS oauth2 endpoint, the caller will also need to specify an mTLS-enabled HTTPClient via the "context" mechanism for use by the OAuth2 transport.

Change-Id: Ic83342ec1d224d3acdabf00d863249330424fc54
GitHub-Last-Rev: 07e4849
GitHub-Pull-Request: #630
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/470396
Run-TryBot: Matthew Hickford <[email protected]>
Reviewed-by: Shin Fan <[email protected]>
Run-TryBot: Shin Fan <[email protected]>
Reviewed-by: Matthew Hickford <[email protected]>
Reviewed-by: Andy Zhao <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/470396 has been merged.

@gopherbot gopherbot closed this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyrzhao @gopherbot