google: manual testing fixes #475
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Change-Id: Icf21d58732fdf4e3caaca015bc10d84613d0f423
gIthuriel
force-pushed
the
manualTestingFixes
branch
from
2a47248 to
f9a4493
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: f9a4493) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/291209 to see it. Tip: You can toggle comments from me using the |
Change-Id: I93775afcec60f24913ed55911b75c01bd44664b3
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: 483d286) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/291209 to see it. Tip: You can toggle comments from me using the |
|
Message from Cody Oss: Patch Set 2: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/291209. |
Change-Id: I037f7313217d75f29f7150c53c1cd28a0ec7ea35
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: 3cb804a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/291209 to see it. Tip: You can toggle comments from me using the |
|
Message from Patrick Jones: Patch Set 3: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/291209. |
|
Message from Cody Oss: Patch Set 3: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/291209. |
|
Message from Patrick Jones: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/291209. |
|
Message from Cody Oss: Patch Set 3: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/291209. |
Change-Id: I591e9aafef142593a9ae2071ead388d9d311552f
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: 5690716) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/oauth2/+/291209 to see it. Tip: You can toggle comments from me using the |
I found some errors while manually testing service account impersonation on Azure. This PR includes the fixes that I made. Change-Id: Ia2b194be6c9a7c843e615f9789c8f8203bcbc151 GitHub-Last-Rev: 5690716 GitHub-Pull-Request: #475 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/291209 Reviewed-by: Cody Oss <[email protected]> Trust: Cody Oss <[email protected]> Trust: Tyler Bui-Palsulich <[email protected]> Run-TryBot: Cody Oss <[email protected]> TryBot-Result: Go Bot <[email protected]>
|
This PR is being closed because golang.org/cl/291209 has been merged. |
I found some errors while manually testing service account impersonation on Azure. This PR includes the fixes that I made.