Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google: support url-sourced 3rd party credentials #466

Closed
wants to merge 5 commits into from
Closed

google: support url-sourced 3rd party credentials #466

wants to merge 5 commits into from

Conversation

gIthuriel
Copy link
Contributor

Implements functionality to allow for URL-sourced 3rd party credentials, expanding the functionality added in #462 .

@gIthuriel
First steps.
d2fc13d 
Change-Id: I85f24bcca91afa4060bc0f0b0799ba8abbb8abdb
@gIthuriel
google: add support for url-sourced file credentials.
bf1e050 
Change-Id: I1eddacc506f9268aafc61ba4727ccd75c8d46d28
@gIthuriel
go fmt
3454980 
Change-Id: Ie9d82a9c162eb72f63ebd75a284083eb4318d6d1
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: 3454980) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/283372 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1:

(8 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 1: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gIthuriel
First wave of review updates.
82dc24d 
Change-Id: Ibfe8cb23f12c516d9264fcbbee8d8af64b458c89
@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 1:

(9 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 82dc24d) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/283372 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gIthuriel
Small tweaks.
9571392 
Change-Id: I77b1f7b362c3ed9972e278f06045c603abcdd9d4
@gopherbot
Copy link
Contributor

This PR (HEAD: 9571392) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/oauth2/+/283372 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Patrick Jones:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=3767541c

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Cody Oss:

Patch Set 3: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Tyler Bui-Palsulich:

Patch Set 3: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/283372.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Jan 13, 2021
@gIthuriel @codyoss
google: support url-sourced 3rd party credentials
d3ed898 
Implements functionality to allow for URL-sourced 3rd party credentials, expanding the functionality added in #462 .

Change-Id: Ib7615fb618486612960d60bee6b9a1ecf5de1404
GitHub-Last-Rev: 9571392
GitHub-Pull-Request: #466
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/283372
Run-TryBot: Cody Oss <[email protected]>
TryBot-Result: Go Bot <[email protected]>
Reviewed-by: Cody Oss <[email protected]>
Trust: Tyler Bui-Palsulich <[email protected]>
Trust: Cody Oss <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/283372 has been merged.

@gopherbot gopherbot closed this Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gIthuriel @gopherbot