Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash1: Make comment more precisely describe how to emulate logic from shell #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Hash1: Make comment more precisely describe how to emulate logic from shell #7

wants to merge 1 commit into from

Conversation

charles-dyfis-net
Copy link

The shell command previously given as an example emits paths starting with ./, and without an added prefix. Also, previously, sha256 was run against the sorted list of filenames, not against the contents of
those files (xargs is needed to perform the latter).

This does introduce a GNUism; working with POSIX find might involve adding a sed pipeline element.

@charles-dyfis-net
Hash1: Make comment more precisely describe how to emulate logic from…
abcd998 
… shell

The shell command previously given as an example emits paths starting
with `./`, and without an added prefix. Also, previously, `sha256` was
run against the sorted list of filenames, not against the _contents_ of
those files (`xargs` is needed to perform the latter).

This does introduce a GNUism; working with POSIX `find` might involve
adding a `sed` pipeline element.
@google-cla
Copy link

google-cla bot commented Mar 22, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@gopherbot
Copy link
Contributor

This PR (HEAD: abcd998) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mod/+/394894 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/394894.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/394894.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Bryan Mills:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/394894.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charles-dyfis-net @gopherbot