Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

golint: Removed redundant if ...; err != nil check #388

Closed
wants to merge 1 commit into from
Closed

golint: Removed redundant if ...; err != nil check #388

wants to merge 1 commit into from

Conversation

matryer
Copy link
Contributor

@matryer matryer commented Mar 15, 2018 •
edited by andybons
Loading

This is not within the scope of golint due to the style suggestion not appearing in CodeReviewComments or Effective Go.

This change:

  • Removes testdata/iferr.go (thus removing the test)
  • Removes lintIfError function and references to it

Fixes #363

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@matryer
Copy link
Contributor Author

matryer commented Mar 15, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gopherbot
Copy link

This PR (HEAD: 5bf0c7e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/lint/+/100841 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@matryer
Copy link
Contributor Author

matryer commented Mar 15, 2018

I've tested this locally on my own codebase and it works.

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@matryer matryer changed the title Removed redundent if ...; err != nil check Removed redundant if ...; err != nil check Mar 15, 2018
@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@matryer matryer changed the title Removed redundant if ...; err != nil check golint: Removed redundant if ...; err != nil check Mar 15, 2018
@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 5:

(1 comment)

No problem. Gerrit is unfamiliar to some.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 6: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit Bot:

Uploaded patch set 7: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Bonventre:

Patch Set 7: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/100841.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot closed this in 4653006 Mar 16, 2018
@gopherbot
Copy link

This PR is being closed because golang.org/cl/100841 has been merged.

@andybons andybons mentioned this pull request Mar 16, 2018
Closed
@rliebz rliebz mentioned this pull request Jun 29, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matryer @googlebot @gopherbot