log/slog: add DiscardHandler #70296

earthboundkid · 2024-11-12T02:40:57Z

This adds a package-level variable, slog.DiscardHandler, which is a
slog.Handler which performs no output. This serves a similar purpose
to io.Discard.

Fixes #62005

This adds a package-level variable, slog.Discard, which is a slog.Handler which performs no output. This serves a similar purpose to io.Discard. Fixes golang#62005

gopherbot · 2024-11-12T02:45:33Z

This PR (HEAD: 8f714b1) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626486.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-12T02:52:30Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T04:14:26Z

Message from Ian Lance Taylor:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T04:14:26Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-12T04:06:26Z","revision":"62178854c5227d6614456061319034180eceb5e5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T04:21:22Z

Message from Ian Lance Taylor:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T04:21:22Z

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results):

go on master (change 626486)

Build or test failure, click here for results.

To reproduce, try gomote repro 8731505597253371713.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T04:21:23Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T13:16:56Z

This PR (HEAD: 5443570) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626486.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-12T17:43:57Z

Message from Jonathan Amsterdam:

Patch Set 3: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T17:52:11Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-12T17:35:16Z","revision":"ccceedb8e6ba186e1e5cec5579eed1017d68ddc1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:01:00Z

Message from Jonathan Amsterdam:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:01:00Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 626486)

Build or test failure, click here for results.

To reproduce, try gomote repro 8731454709552251889.

Additional links for debugging:

Output for go tool dist test -json [shard 2]

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:01:01Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:01:13Z

This PR (HEAD: 3f05e6a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626486.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-12T18:08:58Z

Message from Jonathan Amsterdam:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:08:59Z

Message from Carlana Johnson:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:45:58Z

Message from Jonathan Amsterdam:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T18:53:54Z

Message from Jonathan Amsterdam:

Patch Set 4: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T19:37:44Z

Message from Carlana Johnson:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T19:37:45Z

Message from Jonathan Amsterdam:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-12T20:14:50Z

Message from Carlana Johnson:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:18:19Z

Message from Carlana Johnson:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:36:35Z

Message from Jonathan Amsterdam:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:36:35Z

Message from Carlos Amedee:

Patch Set 5: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:44:48Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:44:49Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-14T17:34:47Z","revision":"3facfa330a8d1a1e7c6bc61138b9cb13e9674863"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:44:49Z

Message from Ian Lance Taylor:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:59:55Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:59:55Z

Message from Go LUCI:

Patch Set 5:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 626486)

Build or test failure, click here for results.

To reproduce, try gomote repro 8731273545720063377.

Additional links for debugging:

Output for go tool dist test -json [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T17:59:56Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:43:53Z

Message from Carlana Johnson:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:44:00Z

This PR (HEAD: 0a61117) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/626486.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-14T19:52:14Z

Message from Jonathan Amsterdam:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:52:15Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-14T19:40:20Z","revision":"3facfa330a8d1a1e7c6bc61138b9cb13e9674863"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T19:52:15Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:31:25Z

Message from Jonathan Amsterdam:

Patch Set 6: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:31:25Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-14T20:20:41Z","revision":"0ff322149e89d7ca1c3083fcd582c084ecc8fae6"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:46:28Z

Message from Jonathan Amsterdam:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:53:58Z

Message from Go LUCI:

Patch Set 6:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-windows-386 has failed with summary (view all results):

go on master (change 626486)

Build or test failure, click here for results.

To reproduce, try gomote repro 8731263108755041505.

Additional links for debugging:

Output for go tool dist test -json [shard 2]

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T20:53:58Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T22:11:29Z

Message from Ian Lance Taylor:

Patch Set 7: Auto-Submit+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-14T22:11:29Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-14T22:03:49Z","revision":"9b74c1bc40641ebdc0e4d926c17d0ab48d8494c1"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/626486.
After addressing review feedback, remember to publish your drafts!

This adds a package-level variable, slog.DiscardHandler, which is a slog.Handler which performs no output. This serves a similar purpose to io.Discard. Fixes #62005 Change-Id: Ia8babc55f860dec9b663a5c400090a7669608fd5 GitHub-Last-Rev: 0a61117 GitHub-Pull-Request: #70296 Reviewed-on: https://go-review.googlesource.com/c/go/+/626486 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>

gopherbot · 2024-11-14T22:34:47Z

This PR is being closed because golang.org/cl/626486 has been merged.

log/slog: add DiscardHandler

8f714b1

This adds a package-level variable, slog.Discard, which is a slog.Handler which performs no output. This serves a similar purpose to io.Discard. Fixes golang#62005

Add release note

5443570

Feedback

3f05e6a

doc fix

0a61117

gopherbot closed this Nov 14, 2024

earthboundkid deleted the cj/discard branch November 14, 2024 22:46

log/slog: add DiscardHandler #70296

log/slog: add DiscardHandler #70296

Conversation

earthboundkid commented Nov 12, 2024 • edited Loading

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 12, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

gopherbot commented Nov 14, 2024

earthboundkid commented Nov 12, 2024 •

edited

Loading