net,net/netip: implement the encoding.(Binary|Text)Appender #69022

apocelipes · 2024-08-22T15:12:44Z

Implement the encoding.TextAppender interface for "net.IP".

Implement the encoding.(Binary|Text)Appender interfaces for
"netip.Addr", "netip.AddrPort" and "netip.Prefix".

"net.IP.MarshalText" also gets some performance improvements:

                      │     old      │                 new                 │
                      │    sec/op    │   sec/op     vs base                │

IPMarshalText/IPv4-8 66.06n ± 1% 14.55n ± 1% -77.97% (p=0.000 n=10)
IPMarshalText/IPv6-8 117.00n ± 1% 63.18n ± 1% -46.00% (p=0.000 n=10)
IPMarshalText/IPv6_long-8 137.8n ± 1% 111.3n ± 1% -19.27% (p=0.000 n=10)
geomean 102.1n 46.77n -54.21%

                      │    old     │                   new                   │
                      │    B/op    │    B/op     vs base                     │

IPMarshalText/IPv4-8 32.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10)
IPMarshalText/IPv6-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10)
IPMarshalText/IPv6_long-8 96.00 ± 0% 48.00 ± 0% -50.00% (p=0.000 n=10)

                      │    old     │                   new                   │
                      │ allocs/op  │ allocs/op   vs base                     │

IPMarshalText/IPv4-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)
IPMarshalText/IPv6-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10)
IPMarshalText/IPv6_long-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10)

All exported types in the standard library that implement the
"encoding.(Binary|Text)Marshaler" now also implement the
"encoding.(Binary|Text)Appender".

Fixes #62384

gopherbot · 2024-08-22T15:22:42Z

This PR (HEAD: 4ebb58e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T15:29:55Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T15:30:04Z

This PR (HEAD: 75e6f0d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T15:36:55Z

Message from kyose chang:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T17:33:15Z

Message from Ian Lance Taylor:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T17:50:09Z

Message from Mateusz Poliwczak:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T17:50:10Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T17:57:31Z

Message from Mateusz Poliwczak:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T17:57:31Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T18:32:52Z

This PR (HEAD: ac1d994) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T18:39:43Z

Message from kyose chang:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T20:29:50Z

Message from Damien Neil:

Patch Set 3:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T23:10:47Z

This PR (HEAD: 7c3dd9b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-22T23:17:25Z

Message from kyose chang:

Patch Set 4:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T23:24:01Z

Message from kyose chang:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-22T23:24:09Z

This PR (HEAD: 3268c0d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-08-23T00:44:04Z

Message from Ian Lance Taylor:

Patch Set 5: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-23T00:44:04Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-08-23T00:32:54Z","revision":"c863dfcaebad119aa69037e73dd31809ca06a48c"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-23T01:03:54Z

Message from Ian Lance Taylor:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-23T01:03:54Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-23T01:03:55Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-08-27T13:45:42Z

Message from kyose chang:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-03T21:19:55Z

This PR (HEAD: 2e7adac) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-03T21:34:13Z

Message from kyose chang:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T09:06:01Z

This PR (HEAD: e66bcef) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-19T23:43:06Z

Message from Ian Lance Taylor:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

Implement the encoding.TextAppender interface for "net.IP". Implement the encoding.(Binary|Text)Appender interfaces for "netip.Addr", "netip.AddrPort" and "netip.Prefix". "net.IP.MarshalText" gets some performance improvements: │ old │ new │ │ sec/op │ sec/op vs base │ IPMarshalText/IPv4-8 66.06n ± 1% 14.55n ± 1% -77.97% (p=0.000 n=10) IPMarshalText/IPv6-8 117.00n ± 1% 63.18n ± 1% -46.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 137.8n ± 1% 111.3n ± 1% -19.27% (p=0.000 n=10) geomean 102.1n 46.77n -54.21% │ old │ new │ │ B/op │ B/op vs base │ IPMarshalText/IPv4-8 32.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 96.00 ± 0% 48.00 ± 0% -50.00% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ IPMarshalText/IPv4-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10) All exported types in the standard library that implement the "encoding.(Binary|Text)Marshaler" now also implement the "encoding.(Binary|Text)Appender". Fixes golang#62384

gopherbot · 2024-09-20T06:39:02Z

This PR (HEAD: 5d27854) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/607520.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-20T06:46:00Z

Message from kyose chang:

Patch Set 7:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T21:24:21Z

Message from Ian Lance Taylor:

Patch Set 8: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T21:24:21Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-20T21:17:55Z","revision":"dfae05efcafef87101cf7157a7a88c4a2da60ca2"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T21:44:55Z

Message from Ian Lance Taylor:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T21:44:56Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T21:44:56Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-21T03:09:37Z

Message from kyose chang:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

Implement the encoding.TextAppender interface for "net.IP". Implement the encoding.(Binary|Text)Appender interfaces for "netip.Addr", "netip.AddrPort" and "netip.Prefix". "net.IP.MarshalText" also gets some performance improvements: │ old │ new │ │ sec/op │ sec/op vs base │ IPMarshalText/IPv4-8 66.06n ± 1% 14.55n ± 1% -77.97% (p=0.000 n=10) IPMarshalText/IPv6-8 117.00n ± 1% 63.18n ± 1% -46.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 137.8n ± 1% 111.3n ± 1% -19.27% (p=0.000 n=10) geomean 102.1n 46.77n -54.21% │ old │ new │ │ B/op │ B/op vs base │ IPMarshalText/IPv4-8 32.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6-8 48.00 ± 0% 0.00 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 96.00 ± 0% 48.00 ± 0% -50.00% (p=0.000 n=10) │ old │ new │ │ allocs/op │ allocs/op vs base │ IPMarshalText/IPv4-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6-8 2.000 ± 0% 0.000 ± 0% -100.00% (p=0.000 n=10) IPMarshalText/IPv6_long-8 2.000 ± 0% 1.000 ± 0% -50.00% (p=0.000 n=10) All exported types in the standard library that implement the "encoding.(Binary|Text)Marshaler" now also implement the "encoding.(Binary|Text)Appender". Fixes #62384 Change-Id: I7d3da8c5736a1ab9c54b9ac4bd2fbf850f9d1bd0 GitHub-Last-Rev: 5d27854 GitHub-Pull-Request: #69022 Reviewed-on: https://go-review.googlesource.com/c/go/+/607520 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: David Chase <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>

gopherbot · 2024-09-23T18:14:41Z

Message from David Chase:

Patch Set 8: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/607520.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-23T18:22:37Z

This PR is being closed because golang.org/cl/607520 has been merged.

apocelipes force-pushed the feat-net-appender branch from 4ebb58e to 75e6f0d Compare August 22, 2024 15:24

apocelipes force-pushed the feat-net-appender branch from 75e6f0d to ac1d994 Compare August 22, 2024 18:26

apocelipes force-pushed the feat-net-appender branch from ac1d994 to 7c3dd9b Compare August 22, 2024 23:10

apocelipes force-pushed the feat-net-appender branch from 7c3dd9b to 3268c0d Compare August 22, 2024 23:20

apocelipes force-pushed the feat-net-appender branch from 3268c0d to 2e7adac Compare September 3, 2024 21:17

apocelipes force-pushed the feat-net-appender branch from 2e7adac to e66bcef Compare September 19, 2024 09:03

apocelipes force-pushed the feat-net-appender branch from e66bcef to 5d27854 Compare September 20, 2024 06:32

gopherbot closed this Sep 23, 2024

apocelipes deleted the feat-net-appender branch September 24, 2024 00:42

net,net/netip: implement the encoding.(Binary|Text)Appender #69022

net,net/netip: implement the encoding.(Binary|Text)Appender #69022

Conversation

apocelipes commented Aug 22, 2024 • edited Loading

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 22, 2024

gopherbot commented Aug 23, 2024

gopherbot commented Aug 23, 2024

gopherbot commented Aug 23, 2024

gopherbot commented Aug 23, 2024

gopherbot commented Aug 23, 2024

gopherbot commented Aug 27, 2024

gopherbot commented Sep 3, 2024

gopherbot commented Sep 3, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 21, 2024

gopherbot commented Sep 23, 2024

gopherbot commented Sep 23, 2024

apocelipes commented Aug 22, 2024 •

edited

Loading