New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: upgrade Unicode from 13.0.0 to 15.0.0 #57265

Closed

cowtoolz wants to merge 1 commit into golang:master from cowtoolz:master

Contributor

cowtoolz commented Dec 12, 2022

Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates #48621
Fixes #55079


          all: upgrade Unicode from 13.0.0 to 15.0.0

c8885ca

Update unicode/tables.go to reflect changes in the Unicode Standard up to Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an unprintable character. This codepoint was assigned and made printable in Unicode 14.0.0, breaking this test. It has been replaced with the assigned and never-printable U+FFFE to fix the test and provide resiliency in the future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates #48621
Fixes #55079

Contributor

gopherbot commented Dec 12, 2022

This PR (HEAD: c8885ca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/456837 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented Dec 12, 2022

Message from Rob Pike:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 12, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 12, 2022

Message from Robert Griesemer:

Patch Set 1: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 12, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 14, 2022

Message from Rob Pike:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 15, 2022

Message from Than McIntosh:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Dec 16, 2022

Message from William:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jan 20, 2023

Message from Cherry Mui:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/456837.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          all: upgrade Unicode from 13.0.0 to 15.0.0

def0be5

Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates #48621
Fixes #55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885ca
GitHub-Pull-Request: #57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Rob Pike <[email protected]>

Contributor

gopherbot commented Feb 6, 2023

This PR is being closed because golang.org/cl/456837 has been merged.

gopherbot closed this

johanbrandhorst pushed a commit to Pryz/go that referenced this pull request


          all: upgrade Unicode from 13.0.0 to 15.0.0

636dbd7

Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates golang#48621
Fixes golang#55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885ca
GitHub-Pull-Request: golang#57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Rob Pike <[email protected]>

Imacheaterandliar21 suggested changes

View reviewed changes

Imacheaterandliar21 left a comment

Imacheaterandliar21 mentioned this pull request

Message from Gopher Robot: wirespecter/Android-SMS-Interceptor#3

Open

veigaribo pushed a commit to veigaribo/template that referenced this pull request


          all: upgrade Unicode from 13.0.0 to 15.0.0

f2ac58c

Update unicode/tables.go to reflect changes in the Unicode Standard up to
Unicode 15.0.0, released 13 Sept 2022.

In order to accommodate this update, strconv/isPrint has been updated to
reflect changes in printable characters.

Also changed is template/exec_test.go for both text and html packages- in
the test "TestJSEscaping", rune U+FDFF was used as a placeholder for an
unprintable character. This codepoint was assigned and made printable in
Unicode 14.0.0, breaking this test. It has been replaced with the assigned
and never-printable U+FFFE to fix the test and provide resiliency in the
future.

This upgrade bypasses Unicode 14.0.0, but is compatible.

Updates golang/go#48621
Fixes golang/go#55079

Change-Id: I40efd097eb746db0727ebf7437280916d1242e47
GitHub-Last-Rev: c8885cab7a0c23632e1e5a433b1e8d5634a45a30
GitHub-Pull-Request: golang/go#57265
Reviewed-on: https://go-review.googlesource.com/c/go/+/456837
Reviewed-by: Robert Griesemer <[email protected]>
Run-TryBot: Rob Pike <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Reviewed-by: Cherry Mui <[email protected]>
Reviewed-by: Rob Pike <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet