-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net: make go resolver aware of network parameter #45016
Conversation
Currently, the go resolver always send two DNS queries (A and AAAA) even if tcp4/udp4/ip4 or tcp6/udp6/ip6 is used. This can cause unwanted latencies when making IPv4-only or IPv6-only connections. This change make go resolver aware of network parameter. Now, only one A query is sent when tcp4/udp4/ip4 is used, and vice versa for tcp6/udp6/ip6.
This PR (HEAD: 4e50941) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/301709 to see it. Tip: You can toggle comments from me using the |
Message from Emmanuel Odeke: Patch Set 1: Run-TryBot+1 Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Go Bot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=f44f1901 Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Emmanuel Odeke: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Go Bot: Patch Set 1: Build is still in progress... Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed. Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
This PR (HEAD: 3d30c48) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/301709 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Go Bot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=3bc0df2c Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Go Bot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Ian Lance Taylor: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Zhang Boyang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Message from Emmanuel Odeke: Patch Set 2: Trust+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
Currently, the go resolver always send two DNS queries (A and AAAA) even if tcp4/udp4/ip4 or tcp6/udp6/ip6 is used. This can cause unwanted latencies when making IPv4-only or IPv6-only connections. This change make go resolver aware of network parameter. Now, only one A query is sent when tcp4/udp4/ip4 is used, and vice versa for tcp6/udp6/ip6. Fixes #45024 Change-Id: I815f909e6df5f7242cfc900f7dfecca628c3a2c8 GitHub-Last-Rev: 3d30c48 GitHub-Pull-Request: #45016 Reviewed-on: https://go-review.googlesource.com/c/go/+/301709 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Emmanuel Odeke <[email protected]>
Message from Zhang Boyang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/301709. |
This PR is being closed because golang.org/cl/301709 has been merged. |
Currently, the go resolver always send two DNS queries (A and AAAA) even
if tcp4/udp4/ip4 or tcp6/udp6/ip6 is used. This can cause unwanted
latencies when making IPv4-only or IPv6-only connections.
This change make go resolver aware of network parameter. Now, only one A
query is sent when tcp4/udp4/ip4 is used, and vice versa for
tcp6/udp6/ip6.
Fixes #45024