net: use libSystem bindings for DNS resolution on macos if cgo is unavailable #30686

grantseltzer · 2019-03-08T16:54:49Z

This change adds directives to link the res_search function in libSystem.
The corresponding Go function is then used in lookup_darwin.go for
resolution when cgo is disabled. This makes DNS resolution logic more
reliable as macOS has some unique quirks such as the /etc/resolver/
directory for specifying nameservers.

Fixes #12524

gopherbot · 2019-03-08T16:55:54Z

This PR (HEAD: bb803d8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T17:05:06Z

Message from Brad Fitzpatrick:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T17:08:39Z

Message from Elias Naur:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T17:13:23Z

Message from Grant Seltzer Richman:

Patch Set 2:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Ah woops, I will add those now.

Thank you for help testing it. For learning purposes could you also tell me how I can test it myself?

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T17:23:01Z

This PR (HEAD: 044733c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T17:24:43Z

Message from Elias Naur:

Patch Set 2:

Patch Set 2:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Ah woops, I will add those now.

Thank you for help testing it. For learning purposes could you also tell me how I can test it myself?

Take a look at misc/ios/README. It's not trivial :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T18:11:37Z

This PR (HEAD: 86893a3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T18:14:01Z

This PR (HEAD: 75578bc) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T18:38:59Z

This PR (HEAD: b9747ec) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T18:41:55Z

Message from Grant Seltzer Richman:

Patch Set 6:

(2 comments)

Patch Set 2:

Patch Set 2:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Ah woops, I will add those now.

Thank you for help testing it. For learning purposes could you also tell me how I can test it myself?

Take a look at misc/ios/README. It's not trivial :)

Ah alright, thank you! Reading through it now, I just pushed the arm and arm64 assembly.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T19:22:36Z

Message from Elias Naur:

Patch Set 6:

(4 comments)

Patch Set 6:

(2 comments)

Patch Set 2:

Patch Set 2:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Ah woops, I will add those now.

Thank you for help testing it. For learning purposes could you also tell me how I can test it myself?

Take a look at misc/ios/README. It's not trivial :)

Ah alright, thank you! Reading through it now, I just pushed the arm and arm64 assembly.

Thansk. Running "GOARCH=arm64 ./iostest.bash" on my macOS machine gives me:

$ GOARCH=arm64 ./iostest.bash
Building Go cmd/dist using /Users/elias/go1.10.1.
Building Go toolchain1 using /Users/elias/go1.10.1.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, darwin/amd64.
go build net: package using cgo has Go assembly file lookup_darwin_amd64.s
go tool dist: FAILED: /Users/elias/go-tip/pkg/tool/darwin_amd64/go_bootstrap install -gcflags=all= -ldflags=all= std cmd: exit status 1

Note that CGO_ENABLED=1 is required for iOS. Perhaps that means you can get away with stubs for the assembly implementation on arm and arm64.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T20:48:59Z

Message from Grant Seltzer Richman:

Patch Set 6:

Patch Set 6:

(4 comments)

Patch Set 6:

(2 comments)

Patch Set 2:

Patch Set 2:

Patch Set 2:

This will break on iOS because of missing arm and arm64 assembly. If you take a stab at the implementation I can test it.

Ah woops, I will add those now.

Thank you for help testing it. For learning purposes could you also tell me how I can test it myself?

Take a look at misc/ios/README. It's not trivial :)

Ah alright, thank you! Reading through it now, I just pushed the arm and arm64 assembly.

Thansk. Running "GOARCH=arm64 ./iostest.bash" on my macOS machine gives me:

$ GOARCH=arm64 ./iostest.bash
Building Go cmd/dist using /Users/elias/go1.10.1.
Building Go toolchain1 using /Users/elias/go1.10.1.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for host, darwin/amd64.
go build net: package using cgo has Go assembly file lookup_darwin_amd64.s
go tool dist: FAILED: /Users/elias/go-tip/pkg/tool/darwin_amd64/go_bootstrap install -gcflags=all= -ldflags=all= std cmd: exit status 1

Note that CGO_ENABLED=1 is required for iOS. Perhaps that means you can get away with stubs for the assembly implementation on arm and arm64.

Ah alright. I'm having trouble running that script myself but I think it's a problem with my go install. I found a bunch of examples in the runtime package of arm assembly stubs so i'll push those up.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T20:53:14Z

This PR (HEAD: a628c74) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T20:59:02Z

Message from Ian Lance Taylor:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T20:59:02Z

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=323b1189

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:01:53Z

Message from Gobot Gobot:

Patch Set 7:

Build is still in progress...
This change failed on freebsd-amd64-12_0:
See https://storage.googleapis.com/go-build-log/323b1189/freebsd-amd64-12_0_82b37e11.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:03:58Z

Message from Gobot Gobot:

Patch Set 7: TryBot-Result-1

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:14:50Z

This PR (HEAD: 05b9e5f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T21:19:14Z

Message from Ian Lance Taylor:

Patch Set 8:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:19:53Z

Message from Grant Seltzer Richman:

Patch Set 8:

(4 comments)

Had some real silly errors for undefined variables. Turns out the vscode extension i'm used to wasn't installed. Sorry about that.

Also realized the the libcCall() function is in runtime. I can copy it over and all the associated functions and datatypes. I can also move the lookup routines to the runtime package. Any thoughts on what's best? Doesn't look like it's defined anywhere besides runtime.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:28:10Z

Message from Ian Lance Taylor:

Patch Set 8:

Also realized the the libcCall() function is in runtime. I can copy it over and all the associated functions and datatypes. I can also move the lookup routines to the runtime package. Any thoughts on what's best? Doesn't look like it's defined anywhere besides runtime.

Perhaps you can do what the syscall package does. You'll need a small helper in runtime/sys_darwin.go. Or moving a couple of functions to the runtime package is likely fine.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T21:59:27Z

Message from Grant Seltzer Richman:

Patch Set 8:

(1 comment)

Patch Set 8:

Also realized the the libcCall() function is in runtime. I can copy it over and all the associated functions and datatypes. I can also move the lookup routines to the runtime package. Any thoughts on what's best? Doesn't look like it's defined anywhere besides runtime.

Perhaps you can do what the syscall package does. You'll need a small helper in runtime/sys_darwin.go. Or moving a couple of functions to the runtime package is likely fine.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T22:29:15Z

This PR (HEAD: 92de1b3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-08T22:38:43Z

Message from Grant Seltzer Richman:

Patch Set 9:

I've gone ahead and rearranged this change set.

The lookup routines that had GOOS=="darwin" checks are now in their own file in net/lookup_darwin.go

The assembly routines are now in the runtime package. I added an exported function for the resolver search but I'm not happy with that design. I will look into what the syscall package does this weekend.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-03-08T22:39:32Z

This PR (HEAD: 8f42cff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-03-09T21:51:05Z

This PR (HEAD: 45ca41c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Signed-off-by: grant <[email protected]>

gopherbot · 2019-04-01T21:17:15Z

This PR (HEAD: a9ff324) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-01T21:19:29Z

Message from Brad Fitzpatrick:

Patch Set 28: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:20:15Z

Message from Gobot Gobot:

Patch Set 28:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=860cafae

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:27:30Z

Message from Gobot Gobot:

Patch Set 28:

Build is still in progress...
This change failed on linux-amd64:
See https://storage.googleapis.com/go-build-log/860cafae/linux-amd64_76587e43.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:28:13Z

Message from Gobot Gobot:

Patch Set 28: TryBot-Result-1

1 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/860cafae/linux-amd64_76587e43.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:45:28Z

Message from Grant Seltzer Richman:

Patch Set 28:

Patch Set 28: TryBot-Result-1

1 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/860cafae/linux-amd64_76587e43.log

Consult https://build.golang.org/ to see whether they are new failures.

I'm not exactly sure what's going on here, can someone help me diagnose?

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:48:13Z

Message from Keith Randall:

Patch Set 28:

Patch Set 28:

Patch Set 28: TryBot-Result-1

1 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/860cafae/linux-amd64_76587e43.log

Consult https://build.golang.org/ to see whether they are new failures.

I'm not exactly sure what's going on here, can someone help me diagnose?

That looks unrelated, a timeout on something not darwin.
Make a trivial change and push a new version, we'll try the trybots again.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: grant <[email protected]>

gopherbot · 2019-04-01T21:54:03Z

This PR (HEAD: ce26e64) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-01T21:54:49Z

Message from Grant Seltzer Richman:

Patch Set 28:

Patch Set 28:

Patch Set 28:

Patch Set 28: TryBot-Result-1

1 of 19 TryBots failed:
Failed on linux-amd64: https://storage.googleapis.com/go-build-log/860cafae/linux-amd64_76587e43.log

Consult https://build.golang.org/ to see whether they are new failures.

I'm not exactly sure what's going on here, can someone help me diagnose?

That looks unrelated, a timeout on something not darwin.
Make a trivial change and push a new version, we'll try the trybots again.

Sounds good

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:55:32Z

Message from Keith Randall:

Patch Set 29: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T21:55:33Z

Message from Gobot Gobot:

Patch Set 29:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0de65021

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-01T22:04:47Z

Message from Gobot Gobot:

Patch Set 29: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-02T00:32:31Z

Message from Ian Lance Taylor:

Patch Set 29:

Also, Ian is out today & tomorrow. So you might not get a +2 until Wednesday.

This one already has a +2, you don't need to wait for me.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-02T21:26:54Z

Message from Keith Randall:

Patch Set 29:

Patch Set 29:

Also, Ian is out today & tomorrow. So you might not get a +2 until Wednesday.

This one already has a +2, you don't need to wait for me.

Mikio, want to take a final look?
I can vouch for the runtime end of things, but my knowledge of dns is limited.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-02T23:22:09Z

Message from Brad Fitzpatrick:

Patch Set 29:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

Signed-off-by: grant <[email protected]>

gopherbot · 2019-04-03T14:21:28Z

This PR (HEAD: 3c3ff6b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/166297 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2019-04-03T14:22:39Z

Message from Grant Seltzer Richman:

Patch Set 29:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T17:28:50Z

Message from Grant Seltzer Richman:

Patch Set 30:

How's this looking?

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T19:21:46Z

Message from Brad Fitzpatrick:

Patch Set 30: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T19:22:53Z

Message from Gobot Gobot:

Patch Set 30:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0602f513

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T19:30:59Z

Message from Gobot Gobot:

Patch Set 30: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

…vailable This change adds directives to link the res_search function in libSystem. The corresponding Go function is then used in `lookup_darwin.go` for resolution when cgo is disabled. This makes DNS resolution logic more reliable as macOS has some unique quirks such as the `/etc/resolver/` directory for specifying nameservers. Fixes #12524 Change-Id: I367263c4951383965b3ef6491196152f78e614b1 GitHub-Last-Rev: 3c3ff6b GitHub-Pull-Request: #30686 Reviewed-on: https://go-review.googlesource.com/c/go/+/166297 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Keith Randall <[email protected]>

gopherbot · 2019-04-04T19:38:01Z

Message from Brad Fitzpatrick:

Patch Set 30:

RELNOTE=yes

Please don’t reply on this GitHub thread. Visit golang.org/cl/166297.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2019-04-04T19:38:50Z

This PR is being closed because golang.org/cl/166297 has been merged.

googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 8, 2019

grantseltzer mentioned this pull request Mar 8, 2019

net: Support the /etc/resolver DNS resolution configuration hierarchy on OS X when cgo is disabled #12524

Closed

bradfitz changed the title ~~net: Use libSystem bindings for DNS resolution on macos if CGO is unavailable~~ net: use libSystem bindings for DNS resolution on macos if cgo is unavailable Mar 8, 2019

grantseltzer force-pushed the master branch from 86893a3 to 75578bc Compare March 8, 2019 18:11

define stub type and methods for vet

a9ff324

Signed-off-by: grant <[email protected]>

grantseltzer force-pushed the master branch from 2996ef6 to a9ff324 Compare April 1, 2019 21:16

trivial change

ce26e64

Signed-off-by: grant <[email protected]>

Add copyright and fix grammar of comments

3c3ff6b

Signed-off-by: grant <[email protected]>

gopherbot closed this Apr 4, 2019

AaronFriel mentioned this pull request Oct 21, 2022

Ensure builds respect split-DNS configurations on MacOS pulumi/pulumi#9224

Closed

net: use libSystem bindings for DNS resolution on macos if cgo is unavailable #30686

net: use libSystem bindings for DNS resolution on macos if cgo is unavailable #30686

Conversation

grantseltzer commented Mar 8, 2019 • edited Loading

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 8, 2019

gopherbot commented Mar 9, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 1, 2019

gopherbot commented Apr 2, 2019

gopherbot commented Apr 2, 2019

gopherbot commented Apr 2, 2019

gopherbot commented Apr 3, 2019

gopherbot commented Apr 3, 2019

gopherbot commented Apr 4, 2019

gopherbot commented Apr 4, 2019

gopherbot commented Apr 4, 2019

gopherbot commented Apr 4, 2019

gopherbot commented Apr 4, 2019

gopherbot commented Apr 4, 2019

grantseltzer commented Mar 8, 2019 •

edited

Loading