-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/ld: symbols missing first letter of package name #8906
Labels
Milestone
Comments
it happens on darwin certainly, see attached which is the output of nm -m. % clang --version Apple LLVM version 6.0 (clang-600.0.47) (based on LLVM 3.5svn) Target: x86_64-apple-darwin13.4.0 Thread model: posix Attachments:
|
I compiled today's tip, and verified that gofmt contains these symbols: 00000000001e6540 s untime.GoroutineProfile.f 00000000001e6548 s untime.ThreadCreateProfile.f 00000000001e6568 s untime.aeshash.f 00000000001e6550 s untime.aeshash32.f .... 00000000001e67c8 s ync.(*Mutex).Unlock.f 00000000001e67d0 s ync.(*RWMutex).RUnlock.f 00000000001e67d8 s ync.(*RWMutex).Unlock.f 000000000010e9b0 t ync.init.1 000000000010e9e0 t ync.init.2 Seems there is an off-by-one error somewhere (interestingly, all of them are aux symbols created by the compiler.) New regression introduced in 1.4, mark as blocking the release. Labels changed: added release-go1.4, os-macosx, removed release-go1.4maybe. Status changed to Accepted. |
It's my fault. https://golang.org/cl/72280043/diff/220001/src/cmd/ld/macho.c Owner changed to @minux. |
CL https://golang.org/cl/159750043 mentions this issue. |
This issue was closed by revision 8fe5ef4. Status changed to Fixed. |
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
I diffed the output of `nm -n gofmt' before and after this change, and verified that all changes are correct and all corrupted symbol names are fixed. Fixes golang#8906. LGTM=iant, cookieo9 R=golang-codereviews, iant, cookieo9 CC=golang-codereviews https://golang.org/cl/159750043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
I diffed the output of `nm -n gofmt' before and after this change, and verified that all changes are correct and all corrupted symbol names are fixed. Fixes golang#8906. LGTM=iant, cookieo9 R=golang-codereviews, iant, cookieo9 CC=golang-codereviews https://golang.org/cl/159750043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
I diffed the output of `nm -n gofmt' before and after this change, and verified that all changes are correct and all corrupted symbol names are fixed. Fixes golang#8906. LGTM=iant, cookieo9 R=golang-codereviews, iant, cookieo9 CC=golang-codereviews https://golang.org/cl/159750043
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
I diffed the output of `nm -n gofmt' before and after this change, and verified that all changes are correct and all corrupted symbol names are fixed. Fixes golang#8906. LGTM=iant, cookieo9 R=golang-codereviews, iant, cookieo9 CC=golang-codereviews https://golang.org/cl/159750043
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: