Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/cmd: TestCheck failures #69665

Closed
gopherbot opened this issue Sep 27, 2024 · 6 comments
Closed

x/tools/gopls/internal/cmd: TestCheck failures #69665

gopherbot opened this issue Sep 27, 2024 · 6 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCheck"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestCheck
=== PAUSE TestCheck
=== CONT  TestCheck
    integration_test.go:125: gopls check ./a.go: exited with code 2, want success: true (gopls check ./a.go: exit=2 stdout=<<>> stderr=<<runtime: VirtualAlloc of 100007936 bytes failed with errno=1455
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff73d99dd24?, 0x400313e000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1067 +0x38 fp=0xae9cdffc00 sp=0xae9cdffbd0 pc=0x7ff73ce347d8
        runtime.sysUsedOS(0x4000500000, 0x5f60000)
...
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff73d99dd24?, 0x4002ea3000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1067 +0x38 fp=0x6dbb3ffba0 sp=0x6dbb3ffb70 pc=0x7ff73ce347d8
        runtime.sysUsedOS(0x400049c000, 0x5f60000)
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mem_windows.go:83 +0x178 fp=0x6dbb3ffc00 sp=0x6dbb3ffba0 pc=0x7ff73cdd6a68
        runtime.sysUsed(...)
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mem.go:77
        runtime.(*mheap).allocSpan(0x7ff73e399e80, 0x2fb0, 0x0, 0x1)
...
        runtime.unique_runtime_registerUniqueMapCleanup.gowrap1()
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1735 +0x3c fp=0x4000495fd0 sp=0x4000495fa0 pc=0x7ff73cddc91c
        runtime.goexit({})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_arm64.s:1223 +0x4 fp=0x4000495fd0 sp=0x4000495fd0 pc=0x7ff73ce3d834
        created by unique.runtime_registerUniqueMapCleanup in goroutine 1
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1730 +0xa0
        >>)
    integration_test.go:133: gopls check ./a.go ./b.go: stdout does not match [a.go:.* fmt.Sprintf format %s has arg 123 of wrong type int]; got <<>>
    integration_test.go:134: gopls check ./a.go ./b.go: stdout does not match [b.go:.* fmt.Sprintf format %d has arg "123" of wrong type string]; got <<>>
--- FAIL: TestCheck (6.36s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Sep 27, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCheck"
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@d2c1642d release-branch.go1.23@c8c6f9ab x/tools/gopls/internal/cmd.TestCheck (log)
=== RUN   TestCheck
=== PAUSE TestCheck
=== CONT  TestCheck
    integration_test.go:125: gopls check ./a.go: exited with code 2, want success: true (gopls check ./a.go: exit=2 stdout=<<>> stderr=<<runtime: VirtualAlloc of 100007936 bytes failed with errno=1455
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff73d99dd24?, 0x400313e000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1067 +0x38 fp=0xae9cdffc00 sp=0xae9cdffbd0 pc=0x7ff73ce347d8
        runtime.sysUsedOS(0x4000500000, 0x5f60000)
...
        fatal error: out of memory
        
        runtime stack:
        runtime.throw({0x7ff73d99dd24?, 0x4002ea3000?})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/panic.go:1067 +0x38 fp=0x6dbb3ffba0 sp=0x6dbb3ffb70 pc=0x7ff73ce347d8
        runtime.sysUsedOS(0x400049c000, 0x5f60000)
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mem_windows.go:83 +0x178 fp=0x6dbb3ffc00 sp=0x6dbb3ffba0 pc=0x7ff73cdd6a68
        runtime.sysUsed(...)
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mem.go:77
        runtime.(*mheap).allocSpan(0x7ff73e399e80, 0x2fb0, 0x0, 0x1)
...
        runtime.unique_runtime_registerUniqueMapCleanup.gowrap1()
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1735 +0x3c fp=0x4000495fd0 sp=0x4000495fa0 pc=0x7ff73cddc91c
        runtime.goexit({})
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/asm_arm64.s:1223 +0x4 fp=0x4000495fd0 sp=0x4000495fd0 pc=0x7ff73ce3d834
        created by unique.runtime_registerUniqueMapCleanup in goroutine 1
        	C:/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mgc.go:1730 +0xa0
        >>)
    integration_test.go:133: gopls check ./a.go ./b.go: stdout does not match [a.go:.* fmt.Sprintf format %s has arg 123 of wrong type int]; got <<>>
    integration_test.go:134: gopls check ./a.go ./b.go: stdout does not match [b.go:.* fmt.Sprintf format %d has arg "123" of wrong type string]; got <<>>
--- FAIL: TestCheck (6.36s)
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@f8ce0052 release-branch.go1.23@c8c6f9ab x/tools/gopls/internal/cmd.TestCheck [ABORT] (log)
=== RUN   TestCheck
=== PAUSE TestCheck
=== CONT  TestCheck

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Sep 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Sep 27, 2024
@adonovan
Copy link
Member

Dup of #69664

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCheck"
2024-09-27 22:10 x_tools-gotip-windows-amd64-race tools@66afc1a4 go@846fc634 x/tools/gopls/internal/cmd.TestCheck [ABORT] (log)
=== RUN   TestCheck
=== PAUSE TestCheck
=== CONT  TestCheck

watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Sep 30, 2024
@adonovan
Copy link
Member

Still a dup of #69664

@adonovan adonovan closed this as not planned Won't fix, can't repro, duplicate, stale Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Sep 30, 2024
@gopherbot gopherbot reopened this Oct 5, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/cmd" && test == "TestCheck"
2024-10-05 11:54 x_tools-go1.23-windows-amd64-race tools@89a53114 release-branch.go1.23@9563300f x/tools/gopls/internal/cmd.TestCheck (log)
=== RUN   TestCheck
=== PAUSE TestCheck
=== CONT  TestCheck
    integration_test.go:133: gopls check ./a.go ./b.go: stdout does not match [a.go:.* fmt.Sprintf format %s has arg 123 of wrong type int]; got <<>>
    integration_test.go:134: gopls check ./a.go ./b.go: stdout does not match [b.go:.* fmt.Sprintf format %d has arg "123" of wrong type string]; got <<>>
--- FAIL: TestCheck (792.26s)

watchflakes

@github-project-automation github-project-automation bot moved this from Done to Active in Test Flakes Oct 5, 2024
@findleyr
Copy link
Member

Unbelievably slow builder. Going to chalk this up to builder issues, unless it recurs.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants