-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: OOM on windows-arm64 builder #69664
Comments
Found new dashboard test flakes for:
2024-09-22 20:55 x_tools-go1.22-windows-arm64 tools@d2c1642d release-branch.go1.22@b4086b7c x/tools/gopls/internal/cmd.TestHighlight (log)
|
This comment was marked as resolved.
This comment was marked as resolved.
Found new dashboard test flakes for:
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@d2c1642d release-branch.go1.23@c8c6f9ab x/tools/gopls/internal/cmd.TestCheck (log)
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@d2c1642d release-branch.go1.23@c8c6f9ab x/tools/gopls/internal/test/integration/completion.TestPackageCompletion/package_completion_without_terminal_newline/default (log)
2024-09-22 20:55 x_tools-go1.22-windows-arm64 tools@f8ce0052 release-branch.go1.22@b4086b7c x/tools/gopls/internal/cmd.TestCodeLens (log)
2024-09-22 20:55 x_tools-go1.22-windows-arm64 tools@f8ce0052 release-branch.go1.22@b4086b7c x/tools/gopls/internal/test/integration/completion.TestDefinition/default (log)
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@f8ce0052 release-branch.go1.23@c8c6f9ab x/tools/gopls/internal/test/integration/completion.TestCompleteAllFields/default [ABORT] (log)
2024-09-22 20:55 x_tools-go1.22-windows-arm64 tools@01bd772b release-branch.go1.22@b4086b7c x/tools/gopls/internal/test/integration/diagnostics.TestTimeFormatAnalyzer/default [ABORT] (log)
2024-09-22 20:55 x_tools-go1.23-windows-arm64 tools@01bd772b release-branch.go1.23@c8c6f9ab [build] (log)
|
Found new dashboard test flakes for:
2024-09-11 02:29 x_text-gotip-windows-arm64 text@38a95c2d go@7c72dc77 make.bat (log)
2024-09-20 19:10 gotip-windows-arm64 go@402dc987 cmd/internal/testdir.Test/fixedbugs/issue20749.go (log)
|
Given that these OOMs started recently, I think we need to investigate recent changes in gopls and/or x/build. I initially thought this may be related to adding a 100MB ballast to gopls (https://go.dev/cl/608796), which on windows unlike linux or darwin actually consumes ram. However, the timing doesn't quite line up. (Nevertheless I will endeavor to remove that ballast, at least for testing). |
Are the OOMs in x/tools ongoing? If it was just that burst around September 20-22, I added some more detail in #66962 (comment) that's likely relevant. |
The OOMs look like they were isolated to that time period. Therefore, closing. Thanks for the context. |
Found new dashboard test flakes for:
2024-10-28 22:46 x_tools-gotip-windows-arm64 tools@45a28e1c go@aef81a75 [build] (log)
2024-10-28 23:45 gotip-windows-arm64 go@98b3be70 cmd/internal/testdir.Test/fixedbugs/issue16037_run.go (log)
|
Found new dashboard test flakes for:
2024-10-29 13:14 gotip-windows-arm64 go@fdfb3067 make.bat (log)
|
This is a builder issue (failing in make.bat). Moving out of the gopls milestone. |
Found new dashboard test flakes for:
2024-11-21 15:52 gotip-windows-arm64 go@02df9bbd cmd/internal/testdir.Test/fixedbugs/issue48558.go (log)
|
Found new dashboard test flakes for:
2024-11-21 18:23 x_tools-gotip-windows-arm64 tools@936a4010 go@b68f8ca8 x/tools/internal/gcimporter.TestStdlib/gotypesalias=1 (log)
|
Found new dashboard test flakes for:
2024-11-21 17:56 x_tools-gotip-windows-arm64 tools@1ffc3a16 go@b68f8ca8 x/tools/internal/gcimporter.TestStdlib/gotypesalias=1 (log)
|
Found new dashboard test flakes for:
2024-11-21 17:56 x_tools-gotip-windows-arm64 tools@442d6be7 go@b68f8ca8 x/tools/gopls/internal/test/integration/misc.TestSimultaneousEdits/default (log)
2024-11-21 17:56 x_tools-gotip-windows-arm64 tools@442d6be7 go@b68f8ca8 x/tools/gopls/internal/test/integration/workspace.TestClearAnalysisDiagnostics/default (log)
|
Found new dashboard test flakes for:
2024-11-22 23:40 x_tools-gotip-windows-arm64 tools@51e54e89 go@c1a0ee37 x/tools/go/packages.TestIssue56632 (log)
|
The latest batch is resolved by restarting these. This is likely to happen again in about a month while the root issue (#66962) is unresolved. |
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: