Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/golangbuild: wrapped command invocation is broken on Windows #68310

Closed
dmitshur opened this issue Jul 4, 2024 · 6 comments
Closed

x/build/cmd/golangbuild: wrapped command invocation is broken on Windows #68310

dmitshur opened this issue Jul 4, 2024 · 6 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jul 4, 2024 •
edited
Loading

The latest version of golangbuild fails to correctly wrap the "go test" invocation with "rdb.exe stream". The result is that instead of "rdb.exe", "go.exe" is being invoked instead. For example, see https://ci.chromium.org/b/8743332564145763297:

C:\b\s\w\ir\cache\tools\bin\rdb.exe stream -var goos:windows -var goarch:amd64 -var host_goos:windows -var host_goarch:amd64 -var builder:x_debug-gotip-windows-amd64 -var go_branch:master -tag bootstrap_version:1.20.6 -tag swarming_bot_id:golang-tryw-win10-us-west1-b-0-85le -- C:\b\s\w\ir\cache\tools\bin\result_adapter.exe go -v=false -dump-json C:\b\s\w\ir\x\w\go.testjson -- C:\b\s\w\ir\x\w\goroot\bin\go test -json -short ./...

go stream: unknown command
Run 'go help' for usage.

The change in CL 581695 for issue #66586 is a plausible culprit.
@dmitshur dmitshur added OS-Windows Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations) labels Jul 4, 2024
@dmitshur dmitshur added this to the Unreleased milestone Jul 4, 2024
@dmitshur dmitshur self-assigned this Jul 4, 2024
@dmitshur dmitshur moved this to In Progress in Go Release Jul 4, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/596815 mentions this issue: main.star: pin golangbuild to version with working command wrapping

@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 4, 2024

As a mitigation to unbreak Windows builders, CL 596815 pins the previous golangbuild version.

@dmitshur dmitshur pinned this issue Jul 4, 2024
@dmitshur dmitshur added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed FixPending Issues that have a fix which has not yet been reviewed or submitted. labels Jul 4, 2024
gopherbot pushed a commit to golang/build that referenced this issue Jul 4, 2024
@dmitshur @gopherbot
main.star: pin golangbuild to version with working command wrapping
9625d60 
As a temporary mitigation for breakage on Windows, pin golangbuild
to a previously working version from 6 days ago:

https://chrome-infra-packages.appspot.com/p/infra/experimental/golangbuild/windows-amd64/+/ado1WRaYZcQUWIK3JLxq-bnoBu3RUQYmnYyAYo3kjfEC

For golang/go#68310.

Change-Id: Iaea2bbec618a85cfec57deba2c761ef4e79a18f9
Reviewed-on: https://go-review.googlesource.com/c/build/+/596815
TryBot-Bypass: Dmitri Shuralyov <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
Reviewed-by: Than McIntosh <[email protected]>
Reviewed-by: Dmitri Shuralyov <[email protected]>
@dmitshur dmitshur unpinned this issue Jul 4, 2024
@dmitshur
Copy link
Contributor Author

dmitshur commented Jul 5, 2024 •
edited
Loading

Filed #68314 for the root cause. I'll wait a bit to see how it goes there before coming back to this.

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jul 5, 2024
@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Jul 22, 2024
@dmitshur
Copy link
Contributor Author

Sent crrev.com/c/5730108 to work around the problem, to unblock golangbuild development while is go1.22.6 isn't released yet.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600996 mentions this issue: main.star: unpin golangbuild version

gopherbot pushed a commit to golang/build that referenced this issue Jul 25, 2024
@dmitshur @gopherbot
main.star: unpin golangbuild version
7475b52 
This reverts the temporary change applied in CL 596815.
By now golangbuild has a workaround added to it in crrev.com/c/5730108.

Tested with:

$ led get-build -real-build 8741505627666329441 \
| sed 's/git_revision:3827b7d23334361675d082c87b226aa09f74f855/latest/' \
| led launch
[I 2024-07-24 19:17:28] getting build definition
[I 2024-07-24 19:17:29] Launching the led job as a real build
[I 2024-07-24 19:17:29] LUCI UI: https://ci.chromium.org/b/8741489447033761169

Fixes golang/go#68310.

Change-Id: I1464fa6fcdaaf9a34a8ddc3100a7bd8654529921
Reviewed-on: https://go-review.googlesource.com/c/build/+/600996
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Auto-Submit: Dmitri Shuralyov <[email protected]>
@gopherbot
Copy link
Contributor

gopherbot commented Jul 25, 2024 •
edited by dmitshur
Loading

Closed by merging CL 600996 (commit golang/build@7475b52) to luci-config.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows Soon This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot